Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

chrome/browser/search/hotword_service.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/search/hotword_service.h"
 
 #include "base/i18n/case_conversion.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
 #include "base/path_service.h"
@@ skipping 342 matching lines @@
   // change so it's okay to reinstall.
   reinstall_pending_ = true;
 
   return UninstallHotwordExtension(extension_service);
 }
 
 bool HotwordService::UninstallHotwordExtension(
     ExtensionService* extension_service) {
   base::string16 error;
   if (!extension_service->UninstallExtension(
-          extension_misc::kHotwordExtensionId, true, &error)) {
+          extension_misc::kHotwordExtensionId,
+          ExtensionService::UNINSTALL_REASON_DEFAULT,

[Devlin, 2014/07/01 17:39:10]

This one's tricky.  I'd love to get rid of DEFAULT and rename it to TESTING, but
this is also used for updating itself.  Hmm... I wonder if we should have a
UNINSTALL_REASON_INTERNAL_MANAGEMENT for this stuff.  It would be used for
Hotword, Bookmarks, and maybe the Drive one.  Unfortunately, I'm not entirely
sure that's a much more specific name than "DEFAULT".  WDYT?

[rpaquay, 2014/07/01 22:56:53]

I like the "internal management" idea. I added a comment next to the new entry.

+          &error)) {
     LOG(WARNING) << "Cannot uninstall extension with id "
                  << extension_misc::kHotwordExtensionId
                  << ": " << error;
     reinstall_pending_ = false;
     return false;
   }
   return true;
 }
 
 bool HotwordService::IsServiceAvailable() {
@@ skipping 123 matching lines @@
     return false;
 
   std::string previous_locale =
       profile_->GetPrefs()->GetString(prefs::kHotwordPreviousLanguage);
   std::string locale = GetCurrentLocale(profile_);
 
   // If it's a new locale, then the old extension should be uninstalled.
   return locale != previous_locale &&
       HotwordService::DoesHotwordSupportLanguage(profile_);
 }