Disallow Atomics.wait in ServiceWorker, allow in SharedWorker

Disallow Atomics.wait in ServiceWorker, allow in SharedWorker

Atomics.wait is a blocking call, and is only allowed on certain workers. See
the new web platform tests here:
https://github.com/w3c/web-platform-tests/pull/5569

BUG=chromium:711809
Review-Url: https://codereview.chromium.org/2841003002
Cr-Commit-Position: refs/heads/master@{#468188}
Committed: https://chromium.googlesource.com/chromium/src/+/a82bef3834cf1550ed4e4108ded9795a2f9a4d34

[binji, 2017-04-26 00:56:30]

binji@chromium.org changed reviewers:
+ jochen@chromium.org, nhiroki@chromium.org

[binji, 2017-04-26 00:56:31]

This does not have any LayoutTests yet, but does pass the WPT tests here:
https://github.com/w3c/web-platform-tests/pull/5569

[binji, 2017-04-26 00:57:20]

The CQ bit was checked by binji@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 00:58:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-04-26 01:46:06]

lgtm

https://codereview.chromium.org/2841003002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h
(right):

https://codereview.chromium.org/2841003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h:91:
virtual bool AllowAtomicsWait() { return false; }
IsAtomicsWaitAllowed()? (AllowAtomicsWait() sounds like it flips the flag)

[commit-bot: I haz the power, 2017-04-26 02:48:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 02:48:54]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[binji, 2017-04-26 18:13:35]

binji@chromium.org changed reviewers:
+ japhet@chromium.org
- jochen@chromium.org

[binji, 2017-04-26 18:13:35]

-jochen, +japhet since Jochen is away currently

https://codereview.chromium.org/2841003002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h
(right):

https://codereview.chromium.org/2841003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h:91:
virtual bool AllowAtomicsWait() { return false; }
On 2017/04/26 at 01:46:06, nhiroki wrote:
> IsAtomicsWaitAllowed()? (AllowAtomicsWait() sounds like it flips the flag)

Done.

[binji, 2017-04-26 18:29:52]

The CQ bit was checked by binji@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 18:30:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 20:41:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 20:41:15]

Dry run: This issue passed the CQ dry run.

[binji, 2017-04-28 21:43:41]

japhet: ping

[Nate Chapin, 2017-04-28 21:56:29]

lgtm

[binji, 2017-04-28 21:57:28]

The CQ bit was checked by binji@chromium.org

[binji, 2017-04-28 21:57:28]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/2841003002/#ps20001
(title: "rename to IsAtomicsWaitAllowed")

[commit-bot: I haz the power, 2017-04-28 21:58:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 00:13:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493416648505920,
"parent_rev": "13ee97369ce0dea158c1862cdf48056ddac77d5d", "commit_rev":
"315f943108e9c7b193d67bc75d9ed31f6fcce3bf"}

[commit-bot: I haz the power, 2017-04-29 00:14:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493416648505920,
"parent_rev": "e613d23a1efc2f049070574103625452bffedecf", "commit_rev":
"a82bef3834cf1550ed4e4108ded9795a2f9a4d34"}

[commit-bot: I haz the power, 2017-04-29 00:15:35]

Description was changed from

==========
Disallow Atomics.wait in ServiceWorker, allow in SharedWorker

Atomics.wait is a blocking call, and is only allowed on certain workers. See
the new web platform tests here:
https://github.com/w3c/web-platform-tests/pull/5569

BUG=chromium:711809
==========

to

==========
Disallow Atomics.wait in ServiceWorker, allow in SharedWorker

Atomics.wait is a blocking call, and is only allowed on certain workers. See
the new web platform tests here:
https://github.com/w3c/web-platform-tests/pull/5569

BUG=chromium:711809

Review-Url: https://codereview.chromium.org/2841003002
Cr-Commit-Position: refs/heads/master@{#468188}
Committed:
https://chromium.googlesource.com/chromium/src/+/a82bef3834cf1550ed4e4108ded9...
==========

[commit-bot: I haz the power, 2017-04-29 00:15:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a82bef3834cf1550ed4e4108ded9...