Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1258)

Unified Diff: third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

Issue 2841003002: Disallow Atomics.wait in ServiceWorker, allow in SharedWorker (Closed)
Patch Set: rename to IsAtomicsWaitAllowed Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/workers/WorkerThread.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp b/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
index df1c855549616284cc81191861fa9a16353e306a..44a3c9a5a037bdec00abda52d3d23bf995a76a91 100644
--- a/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
+++ b/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
@@ -333,6 +333,9 @@ void WebSharedWorkerImpl::OnScriptLoaderFinished() {
worker_inspector_proxy_->WorkerStartMode(document);
std::unique_ptr<WorkerSettings> worker_settings =
WTF::WrapUnique(new WorkerSettings(document->GetSettings()));
+ WorkerV8Settings worker_v8_settings = WorkerV8Settings::Default();
+ worker_v8_settings.atomics_wait_mode_ =
+ WorkerV8Settings::AtomicsWaitMode::kAllow;
std::unique_ptr<WorkerThreadStartupData> startup_data =
WorkerThreadStartupData::Create(
url_, loading_document_->UserAgent(),
@@ -342,7 +345,7 @@ void WebSharedWorkerImpl::OnScriptLoaderFinished() {
main_script_loader_->GetReferrerPolicy(), starter_origin,
worker_clients, main_script_loader_->ResponseAddressSpace(),
main_script_loader_->OriginTrialTokens(), std::move(worker_settings),
- WorkerV8Settings::Default());
+ worker_v8_settings);
// SharedWorker can sometimes run tasks that are initiated by/associated with
// a document's frame but these documents can be from a different process. So
« no previous file with comments | « third_party/WebKit/Source/core/workers/WorkerThread.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698