Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2840973002:
Fix HLS fullscreen gutter color (Closed)
|
Created:
3 years, 8 months ago by tguilbert Modified:
3 years, 7 months ago Reviewers:
liberato (no reviews please) CC:
chromium-reviews, feature-media-reviews_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org, apacible+watch_chromium.org, erickung+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix HLS fullscreen gutter color
On Android, we currently always tell Blink that we will be using
fullscreen overlays. However, the MediaPlayerRenderer does not support
them, and does not attempt to use them.
The result is that Blink avoids drawing any gutter, which causes the
default background color from the LayerTree to be show instead. When no
overlay has been created, the default color is white.
This CL updates WMPI::SupportsOverlayFullscreenVideo to only return true
when we are not using the MediaPlayerRenderer.
BUG=711888
TEST= manually tested on an HLS and non HLS video.
Review-Url: https://codereview.chromium.org/2840973002
Cr-Commit-Position: refs/heads/master@{#467821}
Committed: https://chromium.googlesource.com/chromium/src/+/1423a66d68562cda92de55d3f247ae1c8a155241
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 18 (10 generated)
tguilbert@chromium.org changed reviewers: + liberato@chromium.org
PTAL! (This is dependent on the parent CL landing first) I think the description could/should be updated to be more accurate to help future readers of blame logs. Do you have any suggestions? Thanks, Thomas
On 2017/04/25 23:07:32, tguilbert wrote: > PTAL! (This is dependent on the parent CL landing first) > > I think the description could/should be updated to be more accurate to help > future readers of blame logs. Do you have any suggestions? > > Thanks, > Thomas description: "attempting to use fullscreen overlays" isn't quite accurate. it's notifying blink that we will be using them, when we're not, that causes the issue. probably also mention where the white gutter comes from: SupportsOverlayFullscreenVideo causes blink to avoid drawing any gutter at all. the background color is provided by the LayerTree for all undrawn pixels. The default color is white, if no overlay has been created. lgtm. thanks -fl
Description was changed from ========== Fix HLS fullscreen gutter color The MediaPlayerRenderer does not currently support the use of overlays. Attempting to use fullscreen overlays when playing HLS videos results in white gutters. This CL updates WMPI::SupportsOverlayFullscreenVideo to only return true when we are not using the MediaPlayerRenderer. BUG=711888 TEST= manually tested on an HLS and non HLS video. ========== to ========== Fix HLS fullscreen gutter color ======================================================================== On Android, we currently always tell Blink that we will be using fullscreen overlays. However, the MediaPlayerRenderer does not support them, and does not attempt to use them. The result is that Blink avoids drawing any gutter, which causes the default background color from the LayerTree to be show instead. When no overlay has been created, the default color is white. This CL updates WMPI::SupportsOverlayFullscreenVideo to only return true when we are not using the MediaPlayerRenderer. BUG=711888 TEST= manually tested on an HLS and non HLS video. ==========
Description was changed from ========== Fix HLS fullscreen gutter color ======================================================================== On Android, we currently always tell Blink that we will be using fullscreen overlays. However, the MediaPlayerRenderer does not support them, and does not attempt to use them. The result is that Blink avoids drawing any gutter, which causes the default background color from the LayerTree to be show instead. When no overlay has been created, the default color is white. This CL updates WMPI::SupportsOverlayFullscreenVideo to only return true when we are not using the MediaPlayerRenderer. BUG=711888 TEST= manually tested on an HLS and non HLS video. ========== to ========== Fix HLS fullscreen gutter color On Android, we currently always tell Blink that we will be using fullscreen overlays. However, the MediaPlayerRenderer does not support them, and does not attempt to use them. The result is that Blink avoids drawing any gutter, which causes the default background color from the LayerTree to be show instead. When no overlay has been created, the default color is white. This CL updates WMPI::SupportsOverlayFullscreenVideo to only return true when we are not using the MediaPlayerRenderer. BUG=711888 TEST= manually tested on an HLS and non HLS video. ==========
The CQ bit was checked by tguilbert@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by tguilbert@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by tguilbert@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493326179893320, "parent_rev":
"cabfb95ba20550e4504e518a73874dade479eef9", "commit_rev":
"1423a66d68562cda92de55d3f247ae1c8a155241"}
Message was sent while issue was closed.
Description was changed from ========== Fix HLS fullscreen gutter color On Android, we currently always tell Blink that we will be using fullscreen overlays. However, the MediaPlayerRenderer does not support them, and does not attempt to use them. The result is that Blink avoids drawing any gutter, which causes the default background color from the LayerTree to be show instead. When no overlay has been created, the default color is white. This CL updates WMPI::SupportsOverlayFullscreenVideo to only return true when we are not using the MediaPlayerRenderer. BUG=711888 TEST= manually tested on an HLS and non HLS video. ========== to ========== Fix HLS fullscreen gutter color On Android, we currently always tell Blink that we will be using fullscreen overlays. However, the MediaPlayerRenderer does not support them, and does not attempt to use them. The result is that Blink avoids drawing any gutter, which causes the default background color from the LayerTree to be show instead. When no overlay has been created, the default color is white. This CL updates WMPI::SupportsOverlayFullscreenVideo to only return true when we are not using the MediaPlayerRenderer. BUG=711888 TEST= manually tested on an HLS and non HLS video. Review-Url: https://codereview.chromium.org/2840973002 Cr-Commit-Position: refs/heads/master@{#467821} Committed: https://chromium.googlesource.com/chromium/src/+/1423a66d68562cda92de55d3f247... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1423a66d68562cda92de55d3f247... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
