Make tab_capture_end2end_tests work as a regular windowed_test_launcher.

Make tab_capture_end2end_tests work as a regular windowed_test_launcher.

Previously, when run under swarming, tab_capture_end2end_tests was
specified in gn_isolate_map.pyl as a 'gpu_test_launcher' rather than
as a 'windowed_test_launcher'. This, plus the way the target needed to
be declared in the BUILD.gn files was causing complications for analyze.

We think that there's no need for this separate kind of test_launcher,
as long as there is a way to tell MB to not actually launch xvfb. This
CL adds that support (by making xvfb.py be aware of a --no-xvfb flag)
and allows us to simplify a few things as a result.

Perhaps more interestingly, this'll allow us to actually get rid of the
console_test_launcher/windowed_test_launcher distinction altogether in
the future, but that's for a follow-up CL.

R=kbr@chromium.org
BUG=714336
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2840953002
Cr-Commit-Position: refs/heads/master@{#467501}
Committed: https://chromium.googlesource.com/chromium/src/+/7dad4681ebb1ef820a076c8391fa16ff1afa21c0

[Dirk Pranke, 2017-04-25 20:30:30]

Description was changed from

==========
Make tab_capture_end2end_tests work as a regular windowed_test_launcher.

Previously, when run under swarming, tab_capture_end2end_tests was
specified in gn_isolate_map.pyl as a 'gpu_test_launcher' rather than
as a 'windowed_test_launcher'. This, plus the way the target needed to
be declared in the BUILD.gn files was causing complications for analyze.

We think that there's no need for this separate kind of test_launcher,
as long as there is a way to tell MB to not actually launch xvfb. This
CL adds that support (by making xvfb.py be aware of a --no-xvfb flag)
and allows us to simplify a few things as a result.

Perhaps more interestingly, this'll allow us to actually get rid of the
console_test_launcher/windowed_test_launcher distinction altogether in
the future, but that's for a follow-up CL.

R=kbr@chromium.org
BUG=714336
==========

to

==========
Make tab_capture_end2end_tests work as a regular windowed_test_launcher.

Previously, when run under swarming, tab_capture_end2end_tests was
specified in gn_isolate_map.pyl as a 'gpu_test_launcher' rather than
as a 'windowed_test_launcher'. This, plus the way the target needed to
be declared in the BUILD.gn files was causing complications for analyze.

We think that there's no need for this separate kind of test_launcher,
as long as there is a way to tell MB to not actually launch xvfb. This
CL adds that support (by making xvfb.py be aware of a --no-xvfb flag)
and allows us to simplify a few things as a result.

Perhaps more interestingly, this'll allow us to actually get rid of the
console_test_launcher/windowed_test_launcher distinction altogether in
the future, but that's for a follow-up CL.

R=kbr@chromium.org
BUG=714336
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Dirk Pranke, 2017-04-25 20:39:05]

https://codereview.chromium.org/2840953002/diff/20001/tools/mb/mb.py
File tools/mb/mb.py (right):

https://codereview.chromium.org/2840953002/diff/20001/tools/mb/mb.py#newcode1070
tools/mb/mb.py:1070: use_xvfb = self.platform == 'linux2' and not android
This is just fixing a formatting nit I noticed during this work.

[Dirk Pranke, 2017-04-26 00:39:47]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 00:40:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Russell (switch to Gerrit), 2017-04-26 00:55:45]

LGTM. Thanks Dirk for doing this.

https://codereview.chromium.org/2840953002/diff/20001/content/test/gpu/genera...
File content/test/gpu/generate_buildbot_json.py (right):

https://codereview.chromium.org/2840953002/diff/20001/content/test/gpu/genera...
content/test/gpu/generate_buildbot_json.py:2224: result.pop(key)
Nice cleanup. Thanks.

[commit-bot: I haz the power, 2017-04-26 02:06:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 02:06:38]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2017-04-26 19:21:25]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2017-04-26 19:21:25]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2840953002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-26 19:22:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 21:54:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 21:54:35]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Dirk Pranke, 2017-04-26 22:40:10]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2017-04-26 22:40:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2017-04-26 23:06:44]

The CQ bit was unchecked by dpranke@chromium.org

[Dirk Pranke, 2017-04-26 23:07:05]

Description was changed from

==========
Make tab_capture_end2end_tests work as a regular windowed_test_launcher.

Previously, when run under swarming, tab_capture_end2end_tests was
specified in gn_isolate_map.pyl as a 'gpu_test_launcher' rather than
as a 'windowed_test_launcher'. This, plus the way the target needed to
be declared in the BUILD.gn files was causing complications for analyze.

We think that there's no need for this separate kind of test_launcher,
as long as there is a way to tell MB to not actually launch xvfb. This
CL adds that support (by making xvfb.py be aware of a --no-xvfb flag)
and allows us to simplify a few things as a result.

Perhaps more interestingly, this'll allow us to actually get rid of the
console_test_launcher/windowed_test_launcher distinction altogether in
the future, but that's for a follow-up CL.

R=kbr@chromium.org
BUG=714336
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Make tab_capture_end2end_tests work as a regular windowed_test_launcher.

Previously, when run under swarming, tab_capture_end2end_tests was
specified in gn_isolate_map.pyl as a 'gpu_test_launcher' rather than
as a 'windowed_test_launcher'. This, plus the way the target needed to
be declared in the BUILD.gn files was causing complications for analyze.

We think that there's no need for this separate kind of test_launcher,
as long as there is a way to tell MB to not actually launch xvfb. This
CL adds that support (by making xvfb.py be aware of a --no-xvfb flag)
and allows us to simplify a few things as a result.

Perhaps more interestingly, this'll allow us to actually get rid of the
console_test_launcher/windowed_test_launcher distinction altogether in
the future, but that's for a follow-up CL.

R=kbr@chromium.org
BUG=714336
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true
==========

[Dirk Pranke, 2017-04-26 23:07:09]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2017-04-26 23:07:57]

Marking as NOTRY=true to get this to land; I believe the linux_android_rel_ng
failure is unrelated, but since this file is changing build configs, we don't
retry without the patch and so this keeps getting stuck.

Since I think the bug this is fixing is affecting other builds, we need to land
it ASAP.

[commit-bot: I haz the power, 2017-04-26 23:07:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 23:15:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493248029416020,
"parent_rev": "348eafc5e89c9537b196af6d58c09762d173df0d", "commit_rev":
"7dad4681ebb1ef820a076c8391fa16ff1afa21c0"}

[commit-bot: I haz the power, 2017-04-26 23:15:12]

Description was changed from

==========
Make tab_capture_end2end_tests work as a regular windowed_test_launcher.

Previously, when run under swarming, tab_capture_end2end_tests was
specified in gn_isolate_map.pyl as a 'gpu_test_launcher' rather than
as a 'windowed_test_launcher'. This, plus the way the target needed to
be declared in the BUILD.gn files was causing complications for analyze.

We think that there's no need for this separate kind of test_launcher,
as long as there is a way to tell MB to not actually launch xvfb. This
CL adds that support (by making xvfb.py be aware of a --no-xvfb flag)
and allows us to simplify a few things as a result.

Perhaps more interestingly, this'll allow us to actually get rid of the
console_test_launcher/windowed_test_launcher distinction altogether in
the future, but that's for a follow-up CL.

R=kbr@chromium.org
BUG=714336
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true
==========

to

==========
Make tab_capture_end2end_tests work as a regular windowed_test_launcher.

Previously, when run under swarming, tab_capture_end2end_tests was
specified in gn_isolate_map.pyl as a 'gpu_test_launcher' rather than
as a 'windowed_test_launcher'. This, plus the way the target needed to
be declared in the BUILD.gn files was causing complications for analyze.

We think that there's no need for this separate kind of test_launcher,
as long as there is a way to tell MB to not actually launch xvfb. This
CL adds that support (by making xvfb.py be aware of a --no-xvfb flag)
and allows us to simplify a few things as a result.

Perhaps more interestingly, this'll allow us to actually get rid of the
console_test_launcher/windowed_test_launcher distinction altogether in
the future, but that's for a follow-up CL.

R=kbr@chromium.org
BUG=714336
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2840953002
Cr-Commit-Position: refs/heads/master@{#467501}
Committed:
https://chromium.googlesource.com/chromium/src/+/7dad4681ebb1ef820a076c8391fa...
==========

[commit-bot: I haz the power, 2017-04-26 23:15:14]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7dad4681ebb1ef820a076c8391fa...

[Ken Russell (switch to Gerrit), 2017-04-26 23:23:40]

On 2017/04/26 23:07:57, Dirk Pranke wrote:
> Marking as NOTRY=true to get this to land; I believe the linux_android_rel_ng
> failure is unrelated, but since this file is changing build configs, we don't
> retry without the patch and so this keeps getting stuck.
> 
> Since I think the bug this is fixing is affecting other builds, we need to
land
> it ASAP.

Sounds fine. Could you please file a bug about the linux_android_rel_ng failure
though?

[Dirk Pranke, 2017-04-26 23:36:51]

On 2017/04/26 23:23:40, Ken Russell wrote:
> On 2017/04/26 23:07:57, Dirk Pranke wrote:
> > Marking as NOTRY=true to get this to land; I believe the
linux_android_rel_ng
> > failure is unrelated, but since this file is changing build configs, we
don't
> > retry without the patch and so this keeps getting stuck.
> > 
> > Since I think the bug this is fixing is affecting other builds, we need to
> land
> > it ASAP.
> 
> Sounds fine. Could you please file a bug about the linux_android_rel_ng
failure
> though?

I think the failure showed up on the waterfall, and it appears to have cycled
green.
I'm not sure if someone fixed something, or what:

https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/4...