Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: testing/xvfb.py

Issue 2840953002: Make tab_capture_end2end_tests work as a regular windowed_test_launcher. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « testing/buildbot/gn_isolate_map.pyl ('k') | tools/mb/mb.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/xvfb.py
diff --git a/testing/xvfb.py b/testing/xvfb.py
index 3ca9aa8aa154902b87d410a4b93ce223015b27a8..e51d3c48f507453de9288546eb4b68a183e44cc3 100755
--- a/testing/xvfb.py
+++ b/testing/xvfb.py
@@ -48,7 +48,18 @@ def run_executable(cmd, env):
Returns the exit code of the specified commandline, or 1 on failure.
"""
- if sys.platform == 'linux2':
+
+ # It might seem counterintuitive to support a --no-xvfb flag in a script
+ # whose only job is to start xvfb, but doing so allows us to consolidate
+ # the logic in the layers of buildbot scripts so that we *always* use
+ # xvfb by default and don't have to worry about the distinction, it
+ # can remain solely under the control of the test invocation itself.
+ use_xvfb = True
+ if '--no-xvfb' in cmd:
+ use_xvfb = False
+ cmd.remove('--no-xvfb')
+
+ if sys.platform == 'linux2' and use_xvfb:
if env.get('_CHROMIUM_INSIDE_XVFB') == '1':
openbox_proc = None
xcompmgr_proc = None
@@ -81,7 +92,7 @@ def run_executable(cmd, env):
def main():
- USAGE = 'Usage: xvfb.py [command args...]'
+ USAGE = 'Usage: xvfb.py [command [--no-xvfb] args...]'
if len(sys.argv) < 2:
print >> sys.stderr, USAGE
return 2
« no previous file with comments | « testing/buildbot/gn_isolate_map.pyl ('k') | tools/mb/mb.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698