Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 2840923002: Revert of [inspector] always include user scripts in the snapshot. (Closed)

Created:
3 years, 7 months ago by Yang
Modified:
3 years, 7 months ago
Reviewers:
kozy
CC:
v8-reviews_googlegroups.com, Yang, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [inspector] always include user scripts in the snapshot. (patchset #3 id:40001 of https://codereview.chromium.org/2836623002/ ) Reason for revert: So that https://codereview.chromium.org/2841993002/ can be reverted. Original issue's description: > [inspector] always include user scripts in the snapshot. > > V8 can bundle user scripts in the start up snapshot. These are > shared across contexts, and do not work well context groups. > > R=kozyatinskiy@chromium.org > BUG=v8:6274 > > Review-Url: https://codereview.chromium.org/2836623002 > Cr-Commit-Position: refs/heads/master@{#44847} > Committed: https://chromium.googlesource.com/v8/v8/+/9685cfd310a51b2b32f97223069abaaca77405a8 TBR=kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6274 Review-Url: https://codereview.chromium.org/2840923002 Cr-Commit-Position: refs/heads/master@{#44868} Committed: https://chromium.googlesource.com/v8/v8/+/f385b747eb8ce875344822f0a287f9a0bb0acc6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -110 lines) Patch
M src/api.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M src/debug/debug-interface.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/inspector/v8-debugger.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M src/inspector/v8-debugger-script.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/snapshot/startup-serializer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D test/inspector/debugger/step-snapshot.js View 1 chunk +0 lines, -30 lines 0 comments Download
D test/inspector/debugger/step-snapshot-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
M test/inspector/inspector-test.cc View 4 chunks +3 lines, -16 lines 0 comments Download
M test/inspector/task-runner.h View 2 chunks +1 line, -3 lines 0 comments Download
M test/inspector/task-runner.cc View 2 chunks +1 line, -4 lines 0 comments Download
M test/inspector/testcfg.py View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Yang
Created Revert of [inspector] always include user scripts in the snapshot.
3 years, 7 months ago (2017-04-25 19:37:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840923002/1
3 years, 7 months ago (2017-04-25 19:37:27 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-04-25 19:37:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f385b747eb8ce875344822f0a287f9a0bb0...

Powered by Google App Engine
This is Rietveld 408576698