Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2836623002: [inspector] always include user scripts in the snapshot. (Closed)

Created:
3 years, 8 months ago by Yang
Modified:
3 years, 7 months ago
Reviewers:
kozy
CC:
v8-reviews_googlegroups.com, Yang, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] always include user scripts in the snapshot. V8 can bundle user scripts in the start up snapshot. These are shared across contexts, and do not work well context groups. R=kozyatinskiy@chromium.org BUG=v8:6274 Review-Url: https://codereview.chromium.org/2836623002 Cr-Original-Commit-Position: refs/heads/master@{#44847} Committed: https://chromium.googlesource.com/v8/v8/+/9685cfd310a51b2b32f97223069abaaca77405a8 Review-Url: https://codereview.chromium.org/2836623002 Cr-Commit-Position: refs/heads/master@{#44897} Committed: https://chromium.googlesource.com/v8/v8/+/aaaaa80f02a478520a3556c378920c865d98b09e

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -23 lines) Patch
M src/api.cc View 1 2 chunks +9 lines, -3 lines 0 comments Download
M src/debug/debug-interface.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/inspector/v8-debugger.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M src/inspector/v8-debugger-script.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/snapshot/startup-serializer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A test/inspector/debugger/step-snapshot.js View 1 chunk +30 lines, -0 lines 0 comments Download
A test/inspector/debugger/step-snapshot-expected.txt View 1 chunk +33 lines, -0 lines 0 comments Download
M test/inspector/inspector-test.cc View 1 4 chunks +16 lines, -3 lines 0 comments Download
M test/inspector/task-runner.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M test/inspector/task-runner.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M test/inspector/testcfg.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 23 (14 generated)
Yang
3 years, 8 months ago (2017-04-21 13:23:55 UTC) #1
kozy
lgtm, thanks!
3 years, 8 months ago (2017-04-21 15:55:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836623002/1
3 years, 8 months ago (2017-04-25 04:54:43 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/17232) v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, ...
3 years, 8 months ago (2017-04-25 04:56:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836623002/40001
3 years, 7 months ago (2017-04-25 11:34:44 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/9685cfd310a51b2b32f97223069abaaca77405a8
3 years, 7 months ago (2017-04-25 12:08:25 UTC) #16
Yang
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2840923002/ by yangguo@chromium.org. ...
3 years, 7 months ago (2017-04-25 19:37:23 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836623002/40001
3 years, 7 months ago (2017-04-26 14:46:13 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-04-26 15:13:21 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/aaaaa80f02a478520a3556c378920c865d9...

Powered by Google App Engine
This is Rietveld 408576698