MD Settings: Remove usage of deprecated iron-flex-layout.html.

MD Settings: Remove usage of deprecated iron-flex-layout.html.

This CL addresses all of non-CrOS UI surfaces, and powerwash_dialog which is
CrOS only. Remaining CrOS UI will be addressed in follow up CL.

BUG=635633
TEST=Open chrome:md-settings, look at the DevTools console, no more warnings.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2840713002
Cr-Commit-Position: refs/heads/master@{#467529}
Committed: https://chromium.googlesource.com/chromium/src/+/60869ccf490d8a71bdbe64bca909b80b0348d805

[dpapad, 2017-04-24 20:46:45]

Description was changed from

==========
MD Settings: Remove usage of deprecated iron-flex-layout.html, WIP.

BUG=635633
==========

to

==========
MD Settings: Remove usage of deprecated iron-flex-layout.html, WIP.

BUG=635633
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-24 21:07:30]

Description was changed from

==========
MD Settings: Remove usage of deprecated iron-flex-layout.html, WIP.

BUG=635633
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Remove usage of deprecated iron-flex-layout.html.

BUG=635633
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-24 21:08:30]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 21:08:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 23:20:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 23:20:17]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-04-25 00:05:20]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 00:05:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 00:11:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 00:11:28]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-04-25 01:04:08]

Description was changed from

==========
MD Settings: Remove usage of deprecated iron-flex-layout.html.

BUG=635633
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Remove usage of deprecated iron-flex-layout.html.

This CL addresses all of non-CrOS UI surfaces, and powerwash_dialog which is
CrOS only. Remaining CrOS UI will be addressed in follow up CL.

BUG=635633
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-25 01:05:19]

Description was changed from

==========
MD Settings: Remove usage of deprecated iron-flex-layout.html.

This CL addresses all of non-CrOS UI surfaces, and powerwash_dialog which is
CrOS only. Remaining CrOS UI will be addressed in follow up CL.

BUG=635633
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Remove usage of deprecated iron-flex-layout.html.

This CL addresses all of non-CrOS UI surfaces, and powerwash_dialog which is
CrOS only. Remaining CrOS UI will be addressed in follow up CL.

BUG=635633
TEST=Open chrome:md-settings, look at the DevTools console, no more warnings.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-25 01:09:51]

dpapad@chromium.org changed reviewers:
+ michaelpg@chromium.org

[dpapad, 2017-04-25 01:09:52]

I audited all the files in this CL. They fall into one of the following
categories
 
 1) Were indeed using some CSS class from iron-flex-layout, updated to include
    "iron-flex" style module.
 2) Were not using any CSS class from iron-flex-layout anymore (leftover from
previous
    versions of the code), removed the dependency.
 3) Same as 2, but [hidden] attribute is used. Updated by including
settings-shared
    which adds display: none !important, see [1]

I also removed some unnecessary usages of the CSS "block" class, when it was
applied on a
<div> which is already "display: block" by default.

I did a sanity check on the UI, but I might have missed something (which should
be trivial
to fix once we spot it).

[1]
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/settin...

[dpapad, 2017-04-25 23:46:17]

On 2017/04/25 at 01:09:52, dpapad wrote:
> I audited all the files in this CL. They fall into one of the following
categories
>  
>  1) Were indeed using some CSS class from iron-flex-layout, updated to include
>     "iron-flex" style module.
>  2) Were not using any CSS class from iron-flex-layout anymore (leftover from
previous
>     versions of the code), removed the dependency.
>  3) Same as 2, but [hidden] attribute is used. Updated by including
settings-shared
>     which adds display: none !important, see [1]

FYI, I am about to land https://codereview.chromium.org/2838963003, which will
allow me to modify this CL to include cr-hidden-style instead of
settings-shared, when the only useful CSS rule is the [hidden] rule.


> 
> I also removed some unnecessary usages of the CSS "block" class, when it was
applied on a
> <div> which is already "display: block" by default.
> 
> I did a sanity check on the UI, but I might have missed something (which
should be trivial
> to fix once we spot it).
> 
> [1]
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/settin...

[dpapad, 2017-04-26 01:00:08]

Patchset #4 (id:60001) has been deleted

[dpapad, 2017-04-26 01:01:22]

Update settings_main.html and basic_page.html to use cr-hidden-style instead of
settings-shared. PTAL

[dpapad, 2017-04-26 01:01:29]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 01:02:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 02:19:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 02:19:42]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2017-04-26 20:36:42]

lgtm if the Drive setting passes the chromeos sanity check

https://codereview.chromium.org/2840713002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/downloads_page/downloads_page.html
(right):

https://codereview.chromium.org/2840713002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/downloads_page/downloads_page.html:33: <div
class="settings-box">
did you test this change on chromeos? .settings-box is flex-direction: row but I
think these toggle buttons should be stacked vertically. Maybe it works, just
noticed and wanted to make sure chromeos was accounted for :-)

[dpapad, 2017-04-26 21:57:27]

https://codereview.chromium.org/2840713002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/downloads_page/downloads_page.html
(right):

https://codereview.chromium.org/2840713002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/downloads_page/downloads_page.html:33: <div
class="settings-box">
On 2017/04/26 at 20:36:42, michaelpg wrote:
> did you test this change on chromeos? .settings-box is flex-direction: row but
I think these toggle buttons should be stacked vertically. Maybe it works, just
noticed and wanted to make sure chromeos was accounted for :-)

Good catch. Fixed. Restored the "display: block" rule here. I chose to simply
add it directly in this element's style tag, instead of importing the entirety
of iron-positioning [1]. Did the same for the "display: block" I had erroneously
removed in on_startup_page.html.

[1]
https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chro...

[dpapad, 2017-04-26 22:08:19]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2017-04-26 22:08:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2840713002/#ps120001
(title: "Fix broken layout in startup_urls_page.html")

[commit-bot: I haz the power, 2017-04-26 22:09:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 00:34:11]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1493244499482610,
"parent_rev": "efd8268f95f1c7a212e5b6edd521761dd8a00e31", "commit_rev":
"60869ccf490d8a71bdbe64bca909b80b0348d805"}

[commit-bot: I haz the power, 2017-04-27 00:34:35]

Description was changed from

==========
MD Settings: Remove usage of deprecated iron-flex-layout.html.

This CL addresses all of non-CrOS UI surfaces, and powerwash_dialog which is
CrOS only. Remaining CrOS UI will be addressed in follow up CL.

BUG=635633
TEST=Open chrome:md-settings, look at the DevTools console, no more warnings.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Remove usage of deprecated iron-flex-layout.html.

This CL addresses all of non-CrOS UI surfaces, and powerwash_dialog which is
CrOS only. Remaining CrOS UI will be addressed in follow up CL.

BUG=635633
TEST=Open chrome:md-settings, look at the DevTools console, no more warnings.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2840713002
Cr-Commit-Position: refs/heads/master@{#467529}
Committed:
https://chromium.googlesource.com/chromium/src/+/60869ccf490d8a71bdbe64bca909...
==========

[commit-bot: I haz the power, 2017-04-27 00:34:36]

Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/60869ccf490d8a71bdbe64bca909...