Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2838963003: WebUI: Unify [hidden] attribute styling rules. (Closed)

Created:
3 years, 8 months ago by dpapad
Modified:
3 years, 8 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-elements_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-downloads_chromium.org, dbeam+watch-history_chromium.org, David Trainor- moved to gerrit, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-elements_chromium.org, oshima+watch_chromium.org, pam+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, tsergeant
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Unify [hidden] attribute styling rules. This CL addresses MD Settings, History, Downloads and Bookmarks. MD Extensions will be addressed in follow up CL. BUG=635633 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2838963003 Cr-Commit-Position: refs/heads/master@{#467180} Committed: https://chromium.googlesource.com/chromium/src/+/3bccef5b96b6695d40407dc3c4a2e22212730256

Patch Set 1 #

Patch Set 2 : Update MD Bookmarks too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -32 lines) Patch
M chrome/browser/resources/md_bookmarks/shared_style.html View 1 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_downloads/item.html View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_downloads/manager.html View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.html View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_history/shared_style.html View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/settings_shared_css.html View 1 chunk +0 lines, -6 lines 0 comments Download
A ui/webui/resources/cr_elements/hidden_style_css.html View 1 chunk +15 lines, -0 lines 0 comments Download
M ui/webui/resources/cr_elements/shared_style_css.html View 1 chunk +2 lines, -1 line 0 comments Download
M ui/webui/resources/cr_elements_resources.grdp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
dpapad
MD Extensions also has a bunch of repeated [hidden] CSS rules, see https://cs.chromium.org/search/?q=%22%5Bhidden%5D%22+file:%5Esrc/chrome/browser/resources/md_extensions/+package:%5Echromium$&type=cs. I am ...
3 years, 8 months ago (2017-04-25 22:16:04 UTC) #5
Dan Beam
i assume this has no perf impact? lgtm
3 years, 8 months ago (2017-04-25 23:13:43 UTC) #9
dpapad
On 2017/04/25 at 23:13:43, dbeam wrote: > i assume this has no perf impact? lgtm ...
3 years, 8 months ago (2017-04-25 23:33:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838963003/20001
3 years, 8 months ago (2017-04-26 00:25:16 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 00:30:46 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3bccef5b96b6695d40407dc3c4a2...

Powered by Google App Engine
This is Rietveld 408576698