Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2840663004: PendingScript: Unify watching_for_load_ with client_. (Closed)

Created:
3 years, 8 months ago by jbroman
Modified:
3 years, 8 months ago
Reviewers:
hiroshige
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PendingScript: Unify watching_for_load_ with client_. A client is "watching for load" iff it is the client of the PendingScript. These variables are trivially redundant, and so it's simpler to just hold one. BUG=591558 Review-Url: https://codereview.chromium.org/2840663004 Cr-Commit-Position: refs/heads/master@{#467105} Committed: https://chromium.googlesource.com/chromium/src/+/e0e2dc3f7bd8b62483c2c4b8f1739158a1b05c79

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M third_party/WebKit/Source/core/dom/PendingScript.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.cpp View 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
jbroman
Split off from https://codereview.chromium.org/2828193003, as requested. Unifies "watching for load" and "has a client" concepts, ...
3 years, 8 months ago (2017-04-25 19:04:30 UTC) #4
hiroshige
lgtm
3 years, 8 months ago (2017-04-25 19:36:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840663004/1
3 years, 8 months ago (2017-04-25 19:43:50 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 20:53:16 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e0e2dc3f7bd8b62483c2c4b8f173...

Powered by Google App Engine
This is Rietveld 408576698