Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Side by Side Diff: third_party/WebKit/Source/core/dom/PendingScript.h

Issue 2840663004: PendingScript: Unify watching_for_load_ with client_. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/PendingScript.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google, Inc. All Rights Reserved. 2 * Copyright (C) 2010 Google, Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 virtual void RemoveFromMemoryCache() = 0; 99 virtual void RemoveFromMemoryCache() = 0;
100 100
101 void Dispose(); 101 void Dispose();
102 102
103 protected: 103 protected:
104 PendingScript(ScriptElementBase*, const TextPosition& starting_position); 104 PendingScript(ScriptElementBase*, const TextPosition& starting_position);
105 105
106 virtual void DisposeInternal() = 0; 106 virtual void DisposeInternal() = 0;
107 107
108 PendingScriptClient* Client() { return client_; } 108 PendingScriptClient* Client() { return client_; }
109 bool IsWatchingForLoad() const { return watching_for_load_; } 109 bool IsWatchingForLoad() const { return client_; }
110 110
111 virtual void CheckState() const = 0; 111 virtual void CheckState() const = 0;
112 112
113 private: 113 private:
114 bool watching_for_load_;
115
116 // |m_element| must points to the corresponding ScriptLoader's 114 // |m_element| must points to the corresponding ScriptLoader's
117 // ScriptElementBase and thus must be non-null before dispose() is called 115 // ScriptElementBase and thus must be non-null before dispose() is called
118 // (except for unit tests). 116 // (except for unit tests).
119 Member<ScriptElementBase> element_; 117 Member<ScriptElementBase> element_;
120 118
121 TextPosition starting_position_; // Only used for inline script tags. 119 TextPosition starting_position_; // Only used for inline script tags.
122 double parser_blocking_load_start_time_; 120 double parser_blocking_load_start_time_;
123 121
124 Member<PendingScriptClient> client_; 122 Member<PendingScriptClient> client_;
125 }; 123 };
126 124
127 } // namespace blink 125 } // namespace blink
128 126
129 #endif // PendingScript_h 127 #endif // PendingScript_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/PendingScript.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698