Issue 2840623002: Re-land 4ced9f3c7e9534b6b730d: Fix layout of BubbleFrameView when there's only a close button in th…

Issue 2840623002: Re-land 4ced9f3c7e9534b6b730d: Fix layout of BubbleFrameView when there's only a close button in th… (Closed)

Created:
3 years, 8 months ago by Peter Kasting

Modified:
3 years, 8 months ago

Reviewers:
tapted

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

Re-land 4ced9f3c7e9534b6b730d: Fix layout of BubbleFrameView when there's only a close button in the title row. Push the client area down slightly so it doesn't overlap close. This is a bandaid until bug 702196 is fixed. BUG=709380, 702196 TBR=tapted@chromium.org Review-Url: https://codereview.chromium.org/2821893003 Cr-Commit-Position: refs/heads/master@{#465029} (cherry picked from commit eed63750baeef51b69420b637d4e42c6be2c446d) Review-Url: https://codereview.chromium.org/2840623002 . Cr-Commit-Position: refs/branch-heads/3029@{#766} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/77b32554d91e8fd5a1f093038926d262a4bda5a0

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -31 lines)			Patch
M	ui/views/bubble/bubble_frame_view.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/views/bubble/bubble_frame_view_unittest.cc	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	ui/views/window/dialog_delegate_unittest.cc	View	8 chunks	+57 lines, -24 lines	0 comments	Download

Total messages: 2 (1 generated)

Peter Kasting

3 years, 8 months ago (2017-04-24 17:35:14 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
77b32554d91e8fd5a1f093038926d262a4bda5a0.