Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2821893003: Revert "Revert of Fix layout of BubbleFrameView when there's only a close button in the (patchset #… (Closed)

Created:
3 years, 8 months ago by Evan Stade
Modified:
3 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, msw+watch_chromium.org, groby+bubble_chromium.org, rouslan+bubble_chromium.org, hcarmona+bubble_chromium.org, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land 4ced9f3c7e9534b6b730d: Fix layout of BubbleFrameView when there's only a close button in the title row. Push the client area down slightly so it doesn't overlap close. This is a bandaid until bug 702196 is fixed. BUG=709380, 702196 TBR=tapted@chromium.org Review-Url: https://codereview.chromium.org/2821893003 Cr-Commit-Position: refs/heads/master@{#465029} Committed: https://chromium.googlesource.com/chromium/src/+/eed63750baeef51b69420b637d4e42c6be2c446d

Patch Set 1 #

Patch Set 2 : with fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -31 lines) Patch
M ui/views/bubble/bubble_frame_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/bubble/bubble_frame_view_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/views/window/dialog_delegate_unittest.cc View 1 8 chunks +57 lines, -24 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Evan Stade
the fix is the diff between ps1 and ps2.
3 years, 8 months ago (2017-04-17 16:21:54 UTC) #3
Peter Kasting
LGTM
3 years, 8 months ago (2017-04-17 17:31:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821893003/20001
3 years, 8 months ago (2017-04-17 19:41:02 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 21:39:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eed63750baeef51b69420b637d4e...

Powered by Google App Engine
This is Rietveld 408576698