Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2840613006: Change DCHECK to CHECK in LayoutListItem::UpdateListMarkerNumbers (Closed)

Created:
3 years, 8 months ago by eae
Modified:
3 years, 8 months ago
Reviewers:
kojii
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change DCHECK to CHECK in LayoutListItem::UpdateListMarkerNumbers Speculative bug fix. BUG=713671 R=kojii@chromium.org Review-Url: https://codereview.chromium.org/2840613006 Cr-Commit-Position: refs/heads/master@{#467246} Committed: https://chromium.googlesource.com/chromium/src/+/ea39d1dc3b628c867bb78baddbf44e2f017e0456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/layout/LayoutListItem.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
eae
3 years, 8 months ago (2017-04-26 00:52:03 UTC) #1
kojii
lgtm
3 years, 8 months ago (2017-04-26 05:29:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840613006/1
3 years, 8 months ago (2017-04-26 05:29:57 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 05:34:56 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ea39d1dc3b628c867bb78baddbf4...

Powered by Google App Engine
This is Rietveld 408576698