Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutListItem.cpp

Issue 2840613006: Change DCHECK to CHECK in LayoutListItem::UpdateListMarkerNumbers (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2010 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.
5 * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net) 5 * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net)
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 505 matching lines...) Expand 10 before | Expand all | Expand 10 after
516 : NextListItem(list, item); 516 : NextListItem(list, item);
517 } 517 }
518 518
519 void LayoutListItem::UpdateListMarkerNumbers() { 519 void LayoutListItem::UpdateListMarkerNumbers() {
520 // If distribution recalc is needed, updateListMarkerNumber will be re-invoked 520 // If distribution recalc is needed, updateListMarkerNumber will be re-invoked
521 // after distribution is calculated. 521 // after distribution is calculated.
522 if (GetNode()->GetDocument().ChildNeedsDistributionRecalc()) 522 if (GetNode()->GetDocument().ChildNeedsDistributionRecalc())
523 return; 523 return;
524 524
525 Node* list_node = EnclosingList(this); 525 Node* list_node = EnclosingList(this);
526 DCHECK(list_node); 526 CHECK(list_node);
527 527
528 bool is_list_reversed = false; 528 bool is_list_reversed = false;
529 HTMLOListElement* o_list_element = 529 HTMLOListElement* o_list_element =
530 isHTMLOListElement(list_node) ? toHTMLOListElement(list_node) : 0; 530 isHTMLOListElement(list_node) ? toHTMLOListElement(list_node) : 0;
531 if (o_list_element) { 531 if (o_list_element) {
532 o_list_element->ItemCountChanged(); 532 o_list_element->ItemCountChanged();
533 is_list_reversed = o_list_element->IsReversed(); 533 is_list_reversed = o_list_element->IsReversed();
534 } 534 }
535 535
536 // FIXME: The n^2 protection below doesn't help if the elements were inserted 536 // FIXME: The n^2 protection below doesn't help if the elements were inserted
(...skipping 12 matching lines...) Expand all
549 // assume that all the following ones have too. 549 // assume that all the following ones have too.
550 // This gives us the opportunity to stop here and avoid 550 // This gives us the opportunity to stop here and avoid
551 // marking the same nodes again. 551 // marking the same nodes again.
552 break; 552 break;
553 } 553 }
554 item->UpdateValue(); 554 item->UpdateValue();
555 } 555 }
556 } 556 }
557 557
558 } // namespace blink 558 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698