Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2851693002: Worklet: Add step comments in MainThreadWorklet::addModule() (Closed)

Created:
3 years, 7 months ago by nhiroki
Modified:
3 years, 7 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Worklet: Add step comments in MainThreadWorklet::addModule() Spec: https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule BUG=627945 Review-Url: https://codereview.chromium.org/2851693002 Cr-Commit-Position: refs/heads/master@{#467999} Committed: https://chromium.googlesource.com/chromium/src/+/5aea160185999ed1bee581bf5d1a6b5757a5eb8d

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -6 lines) Patch
M third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp View 1 1 chunk +42 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (10 generated)
nhiroki
PTAL, thanks!
3 years, 7 months ago (2017-04-28 07:18:48 UTC) #2
kouhei (in TOK)
lgtm
3 years, 7 months ago (2017-04-28 14:16:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851693002/20001
3 years, 7 months ago (2017-04-28 15:04:50 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 15:11:30 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5aea160185999ed1bee581bf5d1a...

Powered by Google App Engine
This is Rietveld 408576698