Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/setup-isolate-deserialize.cc

Issue 2840493002: [snapshot] full setup delegate should also be able to deserialize. (Closed)
Patch Set: fix comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/setup-isolate.h ('k') | src/setup-isolate-full.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 the V8 project authors. All rights reserved. 1 // Copyright 2017 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/setup-isolate.h" 5 #include "src/setup-isolate.h"
6 6
7 #include "src/base/logging.h" 7 #include "src/base/logging.h"
8 #include "src/interpreter/interpreter.h" 8 #include "src/interpreter/interpreter.h"
9 #include "src/isolate.h" 9 #include "src/isolate.h"
10 #include "src/ostreams.h" 10 #include "src/ostreams.h"
11 11
12 namespace v8 { 12 namespace v8 {
13 namespace internal { 13 namespace internal {
14 14
15 void SetupIsolateDelegate::SetupBuiltins(Isolate* isolate, 15 void SetupIsolateDelegate::SetupBuiltins(Isolate* isolate,
16 bool create_heap_objects) { 16 bool create_heap_objects) {
17 DCHECK(!create_heap_objects); 17 DCHECK(!create_heap_objects);
18 // No actual work to be done; builtins will be deserialized from the snapshot. 18 // No actual work to be done; builtins will be deserialized from the snapshot.
19 isolate->builtins()->MarkInitialized();
20 } 19 }
21 20
22 void SetupIsolateDelegate::SetupInterpreter( 21 void SetupIsolateDelegate::SetupInterpreter(
23 interpreter::Interpreter* interpreter, bool create_heap_objects) { 22 interpreter::Interpreter* interpreter, bool create_heap_objects) {
24 #ifdef V8_USE_SNAPSHOT 23 #ifdef V8_USE_SNAPSHOT
25 if (FLAG_trace_ignition || FLAG_trace_ignition_codegen || 24 if (FLAG_trace_ignition || FLAG_trace_ignition_codegen ||
26 FLAG_trace_ignition_dispatches) { 25 FLAG_trace_ignition_dispatches) {
27 OFStream os(stdout); 26 OFStream os(stdout);
28 os << "Warning: --trace-ignition-* flags must be passed at mksnapshot " 27 os << "Warning: --trace-ignition-* flags must be passed at mksnapshot "
29 << "time or used with nosnapshot builds." << std::endl; 28 << "time or used with nosnapshot builds." << std::endl;
30 } 29 }
31 #endif 30 #endif
32 DCHECK(interpreter->IsDispatchTableInitialized()); 31 DCHECK(interpreter->IsDispatchTableInitialized());
33 } 32 }
34 33
35 } // namespace internal 34 } // namespace internal
36 } // namespace v8 35 } // namespace v8
OLDNEW
« no previous file with comments | « src/setup-isolate.h ('k') | src/setup-isolate-full.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698