Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2840473003: Return WKNavigation from loadRequest and loadPostRequest. (Closed)

Created:
3 years, 8 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 7 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Return WKNavigation from loadRequest and loadPostRequest. This CL (2 of 7) is a part of large refactoring to create NavigationContext when navigation was started, not when it is finished. This refactoring will allow to pass the same instance of NavigationContext to DidStartNavigation and DidFinishNavigation (crbug.com/713836). Also this will allow to associate NavigationItem with NavigationContext object to commit non-latest navigation (crbug.com/712269). This CL makes load*Request API return WKNavigation object, which can be used to store NavigationContext in CRWWKNavigationStates. BUG=713836, 712269 Review-Url: https://codereview.chromium.org/2840473003 Cr-Commit-Position: refs/heads/master@{#470140} Committed: https://chromium.googlesource.com/chromium/src/+/e92530274bb519ab0480a83f877ef62b8e681897

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -25 lines) Patch
M ios/web/web_state/js/crw_js_post_request_loader.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ios/web/web_state/js/crw_js_post_request_loader.mm View 2 chunks +5 lines, -5 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 4 chunks +17 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Eugene But (OOO till 7-30)
3 years, 8 months ago (2017-04-24 14:10:07 UTC) #5
kkhorimoto
lgtm
3 years, 8 months ago (2017-04-25 13:36:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840473003/20001
3 years, 7 months ago (2017-05-08 21:28:23 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 21:45:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e92530274bb519ab0480a83f877e...

Powered by Google App Engine
This is Rietveld 408576698