ios/web/web_state/js/crw_js_post_request_loader.mm - Issue 2840473003: Return WKNavigation from loadRequest and loadPostRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/js/crw_js_post_request_loader.mm

Issue 2840473003: Return WKNavigation from loadRequest and loadPostRequest. (Closed)

Patch Set: Rebased Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/js/crw_js_post_request_loader.mm

diff --git a/ios/web/web_state/js/crw_js_post_request_loader.mm b/ios/web/web_state/js/crw_js_post_request_loader.mm

index 972d59750a819e374c11729089f4be1189e3a92e..1ea0ac31206fbdbb5866016529b15367e425220d 100644

--- a/ios/web/web_state/js/crw_js_post_request_loader.mm

+++ b/ios/web/web_state/js/crw_js_post_request_loader.mm

@@ -75,10 +75,10 @@ NSString* const kSuccessHandlerName = @"POSTSuccessHandler";

return _requestScript;

}

-- (void)loadPOSTRequest:(NSURLRequest*)request

- inWebView:(WKWebView*)webView

- messageRouter:(CRWWKScriptMessageRouter*)messageRouter

- completionHandler:(void (^)(NSError*))completionHandler {

+- (WKNavigation*)loadPOSTRequest:(NSURLRequest*)request

+ inWebView:(WKWebView*)webView

+ messageRouter:(CRWWKScriptMessageRouter*)messageRouter

+ completionHandler:(void (^)(NSError*))completionHandler {

DCHECK([request.HTTPMethod isEqualToString:@"POST"]);

DCHECK(webView);

DCHECK(messageRouter);

@@ -115,7 +115,7 @@ NSString* const kSuccessHandlerName = @"POSTSuccessHandler";

[NSString stringWithFormat:@"<html><script>%@%@</script></html>",

self.requestScript,

[self scriptToExecutePOSTRequest:request]];

- [webView loadHTMLString:HTML baseURL:request.URL];

+ return [webView loadHTMLString:HTML baseURL:request.URL];

}

#pragma mark - Private methods.