Add a test for RenderWidgetHostConnector

Add a test for RenderWidgetHostConnector

A new test got added to render_widget_host_connector_browsertest.cc
which ensures RWHVA gets connected to objects inheriting
RenderWidgetHostConnector regardless of the order in which they
are created. Previously this had a bug resulting in RWHVA not
connected ImeAdapter if RWHVA was created first, hence keeping
soft keyboard from showing up.

Also removed |WebContentsObserver::RenderViewReady()| override. It was
overridden to initialize rwvha in the connector after creation. But it
only covers the following cases:

- connector created -> rwhva created -> RenderViewReady invoked
- rwhva created -> connector created -> RenderViewReady invoked

Can't cover the following case:
 - rwhva created -> RenderViewReady invoked -> connector created
 
Now Initialize() covers them all, the method became redundant.


BUG=713924
Review-Url: https://codereview.chromium.org/2840443002
Cr-Commit-Position: refs/heads/master@{#466877}
Committed: https://chromium.googlesource.com/chromium/src/+/414a9028af64f0e8d7289b16e829d782f4591368

[Jinsuk Kim, 2017-04-24 04:08:40]

Description was changed from

==========
Add a test for RenderWidgetHostConnector

A new test got added to render_widget_host_connector_browsertest.cc
which ensures RWHVA gets connected to objects inheriting
RenderWidgetHostConnector regardless of the order in which they
are created. Previously this had a bug resulting in RWHVA not
connected ImeAdapter if RWHVA was created first, hence keeping
soft keyboard showing up.

BUG=713924
==========

to

==========
Add a test for RenderWidgetHostConnector

A new test got added to render_widget_host_connector_browsertest.cc
which ensures RWHVA gets connected to objects inheriting
RenderWidgetHostConnector regardless of the order in which they
are created. Previously this had a bug resulting in RWHVA not
connected ImeAdapter if RWHVA was created first, hence keeping
soft keyboard from showing up.

BUG=713924
==========

[Jinsuk Kim, 2017-04-24 04:11:39]

jinsukkim@chromium.org changed reviewers:
+ boliu@chromium.org, phajdan.jr@chromium.org

[Jinsuk Kim, 2017-04-24 04:11:40]

phajdan.jr@chromium.org: Please review changes in content/test

boliu@chromium.org: Please review changes in content/browser

Note: The situation which this test is written for was already known. Overrode
|WebContentObserver::RenderViewReady()| to handle it but turned out it is not
enough. In some cases even the overriden method cannot be called since it is
possible that the method call precedes the time when we register the observer to
get the notification.

The correct fix was made in https://crrev.com/2832153002/. This CL removes
|RenderViewReady()| method because the fix made it redundant. Added a test to
verify the change.

[boliu, 2017-04-24 16:35:41]

https://codereview.chromium.org/2840443002/diff/1/content/browser/android/ren...
File content/browser/android/render_widget_host_connector.cc (left):

https://codereview.chromium.org/2840443002/diff/1/content/browser/android/ren...
content/browser/android/render_widget_host_connector.cc:58: void
RenderWidgetHostConnector::Observer::RenderViewReady() {
why is this not needed anymore?

[Jinsuk Kim, 2017-04-24 22:56:47]

On 2017/04/24 16:35:41, boliu wrote:
>
https://codereview.chromium.org/2840443002/diff/1/content/browser/android/ren...
> File content/browser/android/render_widget_host_connector.cc (left):
> 
>
https://codereview.chromium.org/2840443002/diff/1/content/browser/android/ren...
> content/browser/android/render_widget_host_connector.cc:58: void
> RenderWidgetHostConnector::Observer::RenderViewReady() {
> why is this not needed anymore?

It was overridden to initialize rwvha in the connector after creation. But it
only covers the following cases:
- connector created -> rwhva created -> RenderViewReady invoked
- rwhva created -> connector created -> RenderViewReady invoked

Can't cover the following case:
- rwhva created -> RenderViewReady invoked -> connector created

Now Initialize() covers all the cases. For the situation when a new rwhva comes
in, |RenderViewHostChanged| handles the update old -> new.

[boliu, 2017-04-24 23:30:43]

lgtm

On 2017/04/24 22:56:47, Jinsuk Kim wrote:
> On 2017/04/24 16:35:41, boliu wrote:
> >
>
https://codereview.chromium.org/2840443002/diff/1/content/browser/android/ren...
> > File content/browser/android/render_widget_host_connector.cc (left):
> > 
> >
>
https://codereview.chromium.org/2840443002/diff/1/content/browser/android/ren...
> > content/browser/android/render_widget_host_connector.cc:58: void
> > RenderWidgetHostConnector::Observer::RenderViewReady() {
> > why is this not needed anymore?
> 
> It was overridden to initialize rwvha in the connector after creation. But it
> only covers the following cases:
> - connector created -> rwhva created -> RenderViewReady invoked
> - rwhva created -> connector created -> RenderViewReady invoked
> 
> Can't cover the following case:
> - rwhva created -> RenderViewReady invoked -> connector created
> 
> Now Initialize() covers all the cases. For the situation when a new rwhva
comes
> in, |RenderViewHostChanged| handles the update old -> new.

Put that explanation in the description.

[Jinsuk Kim, 2017-04-25 00:19:19]

Description was changed from

==========
Add a test for RenderWidgetHostConnector

A new test got added to render_widget_host_connector_browsertest.cc
which ensures RWHVA gets connected to objects inheriting
RenderWidgetHostConnector regardless of the order in which they
are created. Previously this had a bug resulting in RWHVA not
connected ImeAdapter if RWHVA was created first, hence keeping
soft keyboard from showing up.

BUG=713924
==========

to

==========
Add a test for RenderWidgetHostConnector

A new test got added to render_widget_host_connector_browsertest.cc
which ensures RWHVA gets connected to objects inheriting
RenderWidgetHostConnector regardless of the order in which they
are created. Previously this had a bug resulting in RWHVA not
connected ImeAdapter if RWHVA was created first, hence keeping
soft keyboard from showing up.

Also removed |WebContentsObserver::RenderViewReady()| override. It was
overridden to initialize rwvha in the connector after creation. But it
only covers the following cases:

- connector created -> rwhva created -> RenderViewReady invoked
- rwhva created -> connector created -> RenderViewReady invoked

- Can't cover the following case:
 - rwhva created -> RenderViewReady invoked -> connector created
 
Now Initialize() covers them all, the method became redundant.


BUG=713924
==========

[Jinsuk Kim, 2017-04-25 00:19:43]

Description was changed from

==========
Add a test for RenderWidgetHostConnector

A new test got added to render_widget_host_connector_browsertest.cc
which ensures RWHVA gets connected to objects inheriting
RenderWidgetHostConnector regardless of the order in which they
are created. Previously this had a bug resulting in RWHVA not
connected ImeAdapter if RWHVA was created first, hence keeping
soft keyboard from showing up.

Also removed |WebContentsObserver::RenderViewReady()| override. It was
overridden to initialize rwvha in the connector after creation. But it
only covers the following cases:

- connector created -> rwhva created -> RenderViewReady invoked
- rwhva created -> connector created -> RenderViewReady invoked

- Can't cover the following case:
 - rwhva created -> RenderViewReady invoked -> connector created
 
Now Initialize() covers them all, the method became redundant.


BUG=713924
==========

to

==========
Add a test for RenderWidgetHostConnector

A new test got added to render_widget_host_connector_browsertest.cc
which ensures RWHVA gets connected to objects inheriting
RenderWidgetHostConnector regardless of the order in which they
are created. Previously this had a bug resulting in RWHVA not
connected ImeAdapter if RWHVA was created first, hence keeping
soft keyboard from showing up.

Also removed |WebContentsObserver::RenderViewReady()| override. It was
overridden to initialize rwvha in the connector after creation. But it
only covers the following cases:

- connector created -> rwhva created -> RenderViewReady invoked
- rwhva created -> connector created -> RenderViewReady invoked

Can't cover the following case:
 - rwhva created -> RenderViewReady invoked -> connector created
 
Now Initialize() covers them all, the method became redundant.


BUG=713924
==========

[Jinsuk Kim, 2017-04-25 00:21:05]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 00:21:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 01:09:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 01:09:02]

Dry run: This issue passed the CQ dry run.

[Jinsuk Kim, 2017-04-25 02:00:22]

On 2017/04/24 23:30:43, boliu wrote:
> lgtm
> 
> On 2017/04/24 22:56:47, Jinsuk Kim wrote:
> > On 2017/04/24 16:35:41, boliu wrote:
> > >
> >
>
https://codereview.chromium.org/2840443002/diff/1/content/browser/android/ren...
> > > File content/browser/android/render_widget_host_connector.cc (left):
> > > 
> > >
> >
>
https://codereview.chromium.org/2840443002/diff/1/content/browser/android/ren...
> > > content/browser/android/render_widget_host_connector.cc:58: void
> > > RenderWidgetHostConnector::Observer::RenderViewReady() {
> > > why is this not needed anymore?
> > 
> > It was overridden to initialize rwvha in the connector after creation. But
it
> > only covers the following cases:
> > - connector created -> rwhva created -> RenderViewReady invoked
> > - rwhva created -> connector created -> RenderViewReady invoked
> > 
> > Can't cover the following case:
> > - rwhva created -> RenderViewReady invoked -> connector created
> > 
> > Now Initialize() covers all the cases. For the situation when a new rwhva
> comes
> > in, |RenderViewHostChanged| handles the update old -> new.
> 
> Put that explanation in the description.

Done

[Jinsuk Kim, 2017-04-25 02:00:30]

The CQ bit was checked by jinsukkim@chromium.org

[commit-bot: I haz the power, 2017-04-25 02:01:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 05:15:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493085630296060, "parent_rev":
"9649adfea00cc80e604b54c94492d9833d8f13ea", "commit_rev":
"414a9028af64f0e8d7289b16e829d782f4591368"}

[commit-bot: I haz the power, 2017-04-25 05:16:39]

Description was changed from

==========
Add a test for RenderWidgetHostConnector

A new test got added to render_widget_host_connector_browsertest.cc
which ensures RWHVA gets connected to objects inheriting
RenderWidgetHostConnector regardless of the order in which they
are created. Previously this had a bug resulting in RWHVA not
connected ImeAdapter if RWHVA was created first, hence keeping
soft keyboard from showing up.

Also removed |WebContentsObserver::RenderViewReady()| override. It was
overridden to initialize rwvha in the connector after creation. But it
only covers the following cases:

- connector created -> rwhva created -> RenderViewReady invoked
- rwhva created -> connector created -> RenderViewReady invoked

Can't cover the following case:
 - rwhva created -> RenderViewReady invoked -> connector created
 
Now Initialize() covers them all, the method became redundant.


BUG=713924
==========

to

==========
Add a test for RenderWidgetHostConnector

A new test got added to render_widget_host_connector_browsertest.cc
which ensures RWHVA gets connected to objects inheriting
RenderWidgetHostConnector regardless of the order in which they
are created. Previously this had a bug resulting in RWHVA not
connected ImeAdapter if RWHVA was created first, hence keeping
soft keyboard from showing up.

Also removed |WebContentsObserver::RenderViewReady()| override. It was
overridden to initialize rwvha in the connector after creation. But it
only covers the following cases:

- connector created -> rwhva created -> RenderViewReady invoked
- rwhva created -> connector created -> RenderViewReady invoked

Can't cover the following case:
 - rwhva created -> RenderViewReady invoked -> connector created
 
Now Initialize() covers them all, the method became redundant.


BUG=713924

Review-Url: https://codereview.chromium.org/2840443002
Cr-Commit-Position: refs/heads/master@{#466877}
Committed:
https://chromium.googlesource.com/chromium/src/+/414a9028af64f0e8d7289b16e829...
==========

[commit-bot: I haz the power, 2017-04-25 05:16:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/414a9028af64f0e8d7289b16e829...