Add a test for RenderWidgetHostConnector

content/browser/android/render_widget_host_connector.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/render_widget_host_connector.h"
 
 #include "content/browser/frame_host/interstitial_page_impl.h"
 #include "content/browser/renderer_host/render_widget_host_view_android.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 
 namespace content {
 
 // Observes RenderWidgetHostViewAndroid to keep the instance up to date.
 class RenderWidgetHostConnector::Observer
     : public WebContentsObserver,
       public RenderWidgetHostViewAndroid::DestructionObserver {
  public:
   Observer(WebContents* web_contents, RenderWidgetHostConnector* connector);
   ~Observer() override;
 
   // WebContentsObserver implementation.
-  void RenderViewReady() override;
   void RenderViewHostChanged(RenderViewHost* old_host,
                              RenderViewHost* new_host) override;
   void DidAttachInterstitialPage() override;
   void DidDetachInterstitialPage() override;
   void WebContentsDestroyed() override;
 
   // RenderWidgetHostViewAndroid::DestructionObserver implementation.
   void RenderWidgetHostViewDestroyed(
       RenderWidgetHostViewAndroid* rwhva) override;
 
@@ skipping 15 matching lines @@
     WebContents* web_contents,
     RenderWidgetHostConnector* connector)
     : WebContentsObserver(web_contents),
       connector_(connector),
       active_rwhva_(nullptr) {}
 
 RenderWidgetHostConnector::Observer::~Observer() {
   DCHECK(!active_rwhva_);
 }
 
-void RenderWidgetHostConnector::Observer::RenderViewReady() {

[boliu, 2017/04/24 16:35:41]

why is this not needed anymore?

-  UpdateRenderWidgetHostView(GetRenderWidgetHostViewAndroid());
-}
-
 void RenderWidgetHostConnector::Observer::RenderViewHostChanged(
     RenderViewHost* old_host,
     RenderViewHost* new_host) {
   // |RenderViewHostChanged| is called only for main rwhva change.
   // No need to update connection if an interstitial page is active.
   if (web_contents()->ShowingInterstitialPage())
     return;
 
   auto* new_view = new_host ? static_cast<RenderWidgetHostViewAndroid*>(
                                   new_host->GetWidget()->GetView())
@@ skipping 60 matching lines @@
 }
 
 RenderWidgetHostConnector::~RenderWidgetHostConnector() {}
 
 RenderWidgetHostViewAndroid* RenderWidgetHostConnector::GetRWHVAForTesting()
     const {
   return render_widget_observer_->active_rwhva();
 }
 
 }  // namespace content