Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Issue 2840423002: Merge "Selection API: type attribute should return 'Range' for range-selection in text controls." t… (Closed)

Created:
3 years, 8 months ago by tkent
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Merge "Selection API: type attribute should return 'Range' for range-selection in text controls." to M59 This fixes a regression since Google Chrome 58. New behavior is compatible with WebKit and Edge. Firefox doesn't have 'type' attribute. Implementation: SelectionTemplate<T>::IsCaret() and IsRange() should take care of granularity. BUG=712579 Review-Url: https://codereview.chromium.org/2835063002 Cr-Commit-Position: refs/heads/master@{#466927} (cherry picked from commit ddf851a7d72103c0062bebeb3d3af42b9d5b5c6d) Review-Url: https://codereview.chromium.org/2840423002 . Cr-Commit-Position: refs/branch-heads/3071@{#249} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/5c24f975838b0d961d333f81f66d1c2267dd1d89

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/shadow-tree-exposure.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/shadow-tree-exposure-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionTemplate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionTemplate.cpp View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
3 years, 8 months ago (2017-04-27 01:03:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5c24f975838b0d961d333f81f66d1c2267dd1d89.

Powered by Google App Engine
This is Rietveld 408576698