Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 2835063002: Selection API: type attribute should return 'Range' for range-selection in text controls. (Closed)

Created:
3 years, 8 months ago by tkent
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Selection API: type attribute should return 'Range' for range-selection in text controls. This fixes a regression since Google Chrome 58. New behavior is compatible with WebKit and Edge. Firefox doesn't have 'type' attribute. Implementation: SelectionTemplate<T>::IsCaret() and IsRange() should take care of granularity. BUG=712579 Review-Url: https://codereview.chromium.org/2835063002 Cr-Commit-Position: refs/heads/master@{#466927} Committed: https://chromium.googlesource.com/chromium/src/+/ddf851a7d72103c0062bebeb3d3af42b9d5b5c6d

Patch Set 1 : . #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/shadow-tree-exposure.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/shadow-tree-exposure-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionTemplate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionTemplate.cpp View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (18 generated)
tkent
yosin@, would you review this please?
3 years, 8 months ago (2017-04-25 01:58:47 UTC) #16
yosin_UTC9
lgtm
3 years, 8 months ago (2017-04-25 07:07:13 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835063002/40001
3 years, 8 months ago (2017-04-25 07:07:38 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 08:37:05 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ddf851a7d72103c0062bebeb3d3a...

Powered by Google App Engine
This is Rietveld 408576698