Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2840403002: Don't call DirtyStackingContextZOrderLists during document shutdown (Closed)

Created:
3 years, 7 months ago by chrishtr
Modified:
3 years, 7 months ago
Reviewers:
wkorman
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't call DirtyStackingContextZOrderLists during document shutdown DirtyStackingContextZOrderLists may try to call LayoutView::Compositor(), which may be invalid during such times. In any case, DirtyStackingContextZOrderLists is irrelevant during document shutdown. BUG=715736 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2840403002 Cr-Commit-Position: refs/heads/master@{#467554} Committed: https://chromium.googlesource.com/chromium/src/+/d846315f83096c9b86e9206d901e56fa1190710a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 chunk +12 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
chrishtr
3 years, 7 months ago (2017-04-26 23:23:40 UTC) #4
wkorman
lgtm Is there a way to add a test that used to crash and no ...
3 years, 7 months ago (2017-04-26 23:27:19 UTC) #7
chrishtr
On 2017/04/26 at 23:27:19, wkorman wrote: > lgtm > > Is there a way to ...
3 years, 7 months ago (2017-04-26 23:38:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840403002/1
3 years, 7 months ago (2017-04-26 23:40:10 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 02:28:50 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d846315f83096c9b86e9206d901e...

Powered by Google App Engine
This is Rietveld 408576698