Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 2840403002: Don't call DirtyStackingContextZOrderLists during document shutdown (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
index 1f9148f70c35bc50321b277d0a6b01410f2b6fb7..16f625873668c322d216058212ebb91e6e3d0ab5 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
@@ -1303,18 +1303,19 @@ PaintLayer* PaintLayer::RemoveChild(PaintLayer* old_child) {
if (last_ == old_child)
last_ = old_child->PreviousSibling();
- if (Compositor()) {
- if (!old_child->StackingNode()->IsStacked() &&
- !GetLayoutObject().DocumentBeingDestroyed())
- Compositor()->SetNeedsCompositingUpdate(kCompositingUpdateRebuildTree);
- }
+ if (!GetLayoutObject().DocumentBeingDestroyed()) {
+ if (Compositor()) {
+ if (!old_child->StackingNode()->IsStacked())
+ Compositor()->SetNeedsCompositingUpdate(kCompositingUpdateRebuildTree);
+ }
- if (old_child->StackingNode()->IsStacked() || old_child->FirstChild()) {
- // Dirty the z-order list in which we are contained. When called via the
- // reattachment process in removeOnlyThisLayer, the layer may already be
- // disconnected from the main layer tree, so we need to null-check the
- // |stackingContext| value.
- old_child->StackingNode()->DirtyStackingContextZOrderLists();
+ if (old_child->StackingNode()->IsStacked() || old_child->FirstChild()) {
+ // Dirty the z-order list in which we are contained. When called via the
+ // reattachment process in removeOnlyThisLayer, the layer may already be
+ // disconnected from the main layer tree, so we need to null-check the
+ // |stackingContext| value.
+ old_child->StackingNode()->DirtyStackingContextZOrderLists();
+ }
}
if (GetLayoutObject().Style()->Visibility() != EVisibility::kVisible)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698