Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: third_party/WebKit/Source/core/dom/NodeIteratorBase.h

Issue 2840163002: DOM: NodeIterator.filter and TreeWalker.filter should return values which were specified to createN… (Closed)
Patch Set: Move ToV8() to ToV8ForCore.h, etc. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/NodeIteratorBase.h
diff --git a/third_party/WebKit/Source/core/dom/NodeIteratorBase.h b/third_party/WebKit/Source/core/dom/NodeIteratorBase.h
index 6501a5b22dee9f22d898cf91b1a3d931fa8f0fc8..ddf18519111af6ccfb67d99165799b37445c642e 100644
--- a/third_party/WebKit/Source/core/dom/NodeIteratorBase.h
+++ b/third_party/WebKit/Source/core/dom/NodeIteratorBase.h
@@ -32,13 +32,13 @@ namespace blink {
class ExceptionState;
class Node;
-class NodeFilter;
+class V8NodeFilterCondition;
class NodeIteratorBase : public GarbageCollectedMixin {
public:
Node* root() const { return root_.Get(); }
unsigned whatToShow() const { return what_to_show_; }
- NodeFilter* filter() const { return filter_.Get(); }
+ V8NodeFilterCondition* filter() const { return filter_.Get(); }
DECLARE_VIRTUAL_TRACE();
DECLARE_VIRTUAL_TRACE_WRAPPERS();
@@ -47,13 +47,16 @@ class NodeIteratorBase : public GarbageCollectedMixin {
// In order to properly trace wrappers it is necessary for TraceWrapperMember
// to find the object header from within the mixin. |childThis| is safe to
// find the header so we pass it instead of |this|.
- NodeIteratorBase(void* child_this, Node*, unsigned what_to_show, NodeFilter*);
+ NodeIteratorBase(void* child_this,
+ Node*,
+ unsigned what_to_show,
+ V8NodeFilterCondition*);
unsigned AcceptNode(Node*, ExceptionState&) const;
private:
Member<Node> root_;
unsigned what_to_show_;
- TraceWrapperMember<NodeFilter> filter_;
+ TraceWrapperMember<V8NodeFilterCondition> filter_;
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/dom/NodeIterator.cpp ('k') | third_party/WebKit/Source/core/dom/NodeIteratorBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698