Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: third_party/WebKit/Source/core/dom/NodeIteratorBase.h

Issue 2840163002: DOM: NodeIterator.filter and TreeWalker.filter should return values which were specified to createN… (Closed)
Patch Set: Move ToV8() to ToV8ForCore.h, etc. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2000 Frederik Holljen (frederik.holljen@hig.no) 3 * Copyright (C) 2000 Frederik Holljen (frederik.holljen@hig.no)
4 * Copyright (C) 2001 Peter Kelly (pmk@post.com) 4 * Copyright (C) 2001 Peter Kelly (pmk@post.com)
5 * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2004, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2008 Apple Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 14 matching lines...) Expand all
25 #ifndef NodeIteratorBase_h 25 #ifndef NodeIteratorBase_h
26 #define NodeIteratorBase_h 26 #define NodeIteratorBase_h
27 27
28 #include "bindings/core/v8/TraceWrapperMember.h" 28 #include "bindings/core/v8/TraceWrapperMember.h"
29 #include "platform/heap/Handle.h" 29 #include "platform/heap/Handle.h"
30 30
31 namespace blink { 31 namespace blink {
32 32
33 class ExceptionState; 33 class ExceptionState;
34 class Node; 34 class Node;
35 class NodeFilter; 35 class V8NodeFilterCondition;
36 36
37 class NodeIteratorBase : public GarbageCollectedMixin { 37 class NodeIteratorBase : public GarbageCollectedMixin {
38 public: 38 public:
39 Node* root() const { return root_.Get(); } 39 Node* root() const { return root_.Get(); }
40 unsigned whatToShow() const { return what_to_show_; } 40 unsigned whatToShow() const { return what_to_show_; }
41 NodeFilter* filter() const { return filter_.Get(); } 41 V8NodeFilterCondition* filter() const { return filter_.Get(); }
42 42
43 DECLARE_VIRTUAL_TRACE(); 43 DECLARE_VIRTUAL_TRACE();
44 DECLARE_VIRTUAL_TRACE_WRAPPERS(); 44 DECLARE_VIRTUAL_TRACE_WRAPPERS();
45 45
46 protected: 46 protected:
47 // In order to properly trace wrappers it is necessary for TraceWrapperMember 47 // In order to properly trace wrappers it is necessary for TraceWrapperMember
48 // to find the object header from within the mixin. |childThis| is safe to 48 // to find the object header from within the mixin. |childThis| is safe to
49 // find the header so we pass it instead of |this|. 49 // find the header so we pass it instead of |this|.
50 NodeIteratorBase(void* child_this, Node*, unsigned what_to_show, NodeFilter*); 50 NodeIteratorBase(void* child_this,
51 Node*,
52 unsigned what_to_show,
53 V8NodeFilterCondition*);
51 unsigned AcceptNode(Node*, ExceptionState&) const; 54 unsigned AcceptNode(Node*, ExceptionState&) const;
52 55
53 private: 56 private:
54 Member<Node> root_; 57 Member<Node> root_;
55 unsigned what_to_show_; 58 unsigned what_to_show_;
56 TraceWrapperMember<NodeFilter> filter_; 59 TraceWrapperMember<V8NodeFilterCondition> filter_;
57 }; 60 };
58 61
59 } // namespace blink 62 } // namespace blink
60 63
61 #endif // NodeIteratorBase_h 64 #endif // NodeIteratorBase_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/NodeIterator.cpp ('k') | third_party/WebKit/Source/core/dom/NodeIteratorBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698