third_party/WebKit/Source/core/dom/NodeIterator.cpp - Issue 2840163002: DOM: NodeIterator.filter and TreeWalker.filter should return values which were specified to createN…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/NodeIterator.cpp

Issue 2840163002: DOM: NodeIterator.filter and TreeWalker.filter should return values which were specified to createN… (Closed)

Patch Set: Move ToV8() to ToV8ForCore.h, etc. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/NodeIterator.cpp

diff --git a/third_party/WebKit/Source/core/dom/NodeIterator.cpp b/third_party/WebKit/Source/core/dom/NodeIterator.cpp

index 45ee8ed271386da59b5097dfbbf51f481b9feb23..f74a75bd561c352928568be5488c1c188cc4e467 100644

--- a/third_party/WebKit/Source/core/dom/NodeIterator.cpp

+++ b/third_party/WebKit/Source/core/dom/NodeIterator.cpp

@@ -64,7 +64,7 @@ bool NodeIterator::NodePointer::MoveToPrevious(Node* root) {

NodeIterator::NodeIterator(Node* root_node,

unsigned what_to_show,

- NodeFilter* filter)

+ V8NodeFilterCondition* filter)

: NodeIteratorBase(this, root_node, what_to_show, filter),

reference_node_(root(), true) {

// If NodeIterator target is Attr node, don't subscribe for nodeWillBeRemoved,