Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2840083002: Add UMA for network type at request start (Closed)

Created:
3 years, 8 months ago by Pete Williamson
Modified:
3 years, 8 months ago
Reviewers:
romax, Steven Holte
CC:
chromium-reviews, cbentzel+watch_chromium.org, dewittj+watch_chromium.org, tburkard+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, gavinp+prer_chromium.org, asvitkine+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA for network type at request start BUG=673927 Review-Url: https://codereview.chromium.org/2840083002 Cr-Commit-Position: refs/heads/master@{#467355} Committed: https://chromium.googlesource.com/chromium/src/+/49ce38e06e2307125474c6e9f2db0f47ae45b3e1

Patch Set 1 #

Patch Set 2 : Rebase to remove superflous change in prerendering_offliner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -3 lines) Patch
M components/offline_pages/core/background/request_coordinator.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/offline_pages/core/background/request_coordinator.cc View 7 chunks +31 lines, -3 lines 0 comments Download
M components/offline_pages/core/background/request_coordinator_unittest.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Pete Williamson
Holte: histograms.xml Romax: everything Thanks!
3 years, 8 months ago (2017-04-25 21:54:40 UTC) #4
Steven Holte
lgtm
3 years, 8 months ago (2017-04-26 02:01:57 UTC) #7
romax
lgtm
3 years, 8 months ago (2017-04-26 03:28:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840083002/20001
3 years, 8 months ago (2017-04-26 17:03:32 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 17:09:46 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/49ce38e06e2307125474c6e9f2db...

Powered by Google App Engine
This is Rietveld 408576698