Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: components/offline_pages/core/background/request_coordinator_unittest.cc

Issue 2840083002: Add UMA for network type at request start (Closed)
Patch Set: Rebase to remove superflous change in prerendering_offliner Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/background/request_coordinator_unittest.cc
diff --git a/components/offline_pages/core/background/request_coordinator_unittest.cc b/components/offline_pages/core/background/request_coordinator_unittest.cc
index 5933792f28b5e73907a93fb8132e263b94a9ac46..8bdbba12bd72c3967752b5134d6372727e466c2b 100644
--- a/components/offline_pages/core/background/request_coordinator_unittest.cc
+++ b/components/offline_pages/core/background/request_coordinator_unittest.cc
@@ -784,6 +784,12 @@ TEST_F(RequestCoordinatorTest, OfflinerDoneRequestFailedNoRetryFailure) {
EXPECT_TRUE(observer().completed_called());
EXPECT_EQ(RequestCoordinator::BackgroundSavePageResult::LOADING_FAILURE,
observer().last_status());
+ // We should have a histogram entry for the effective network conditions
+ // when this failed request began.
+ histograms().ExpectBucketCount(
+ "OfflinePages.Background.EffectiveConnectionType.OffliningStartType."
+ "bookmark",
+ net::NetworkChangeNotifier::CONNECTION_UNKNOWN, 1);
}
TEST_F(RequestCoordinatorTest, OfflinerDoneRequestFailedNoNextFailure) {
« no previous file with comments | « components/offline_pages/core/background/request_coordinator.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698