Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Issue 2839973002: Use TaskScheduler instead of blocking pool in external_metrics.cc. (Closed)

Created:
3 years, 8 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, asvitkine+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TaskScheduler instead of blocking pool in external_metrics.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 Review-Url: https://codereview.chromium.org/2839973002 Cr-Commit-Position: refs/heads/master@{#467632} Committed: https://chromium.googlesource.com/chromium/src/+/b4046080f31d65ed2618ecf1a2538ac322e9848a

Patch Set 1 #

Patch Set 2 : add-include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M chrome/browser/chromeos/external_metrics.cc View 1 3 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
fdoray
PTAL
3 years, 8 months ago (2017-04-26 20:26:26 UTC) #10
oshima
lgtm
3 years, 8 months ago (2017-04-26 21:43:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839973002/20001
3 years, 7 months ago (2017-04-27 10:16:44 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 10:21:17 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b4046080f31d65ed2618ecf1a253...

Powered by Google App Engine
This is Rietveld 408576698