Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1893)

Unified Diff: chrome/browser/chromeos/external_metrics.cc

Issue 2839973002: Use TaskScheduler instead of blocking pool in external_metrics.cc. (Closed)
Patch Set: add-include Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/external_metrics.cc
diff --git a/chrome/browser/chromeos/external_metrics.cc b/chrome/browser/chromeos/external_metrics.cc
index dfd88e97ed0f3befa8d7528440a9caf096bef418..fe56b5aa4d9d16e7e4f20a08a9ff458e44f30a13 100644
--- a/chrome/browser/chromeos/external_metrics.cc
+++ b/chrome/browser/chromeos/external_metrics.cc
@@ -16,7 +16,7 @@
#include "base/metrics/sparse_histogram.h"
#include "base/metrics/statistics_recorder.h"
#include "base/metrics/user_metrics.h"
-#include "base/threading/sequenced_worker_pool.h"
+#include "base/task_scheduler/post_task.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/metrics/chromeos_metrics_provider.h"
#include "components/metrics/metrics_service.h"
@@ -48,11 +48,12 @@ bool CheckLinearValues(const std::string& name, int maximum) {
return CheckValues(name, 1, maximum, maximum + 1);
}
-} // namespace
+// The interval between external metrics collections.
+constexpr base::TimeDelta kExternalMetricsCollectionInterval =
+ base::TimeDelta::FromSeconds(30);
+constexpr char kEventsFilePath[] = "/var/lib/metrics/uma-events";
-// The interval between external metrics collections in seconds
-static const int kExternalMetricsCollectionIntervalSeconds = 30;
-const char kEventsFilePath[] = "/var/lib/metrics/uma-events";
+} // namespace
ExternalMetrics::ExternalMetrics() : uma_events_file_(kEventsFilePath) {
}
@@ -171,11 +172,13 @@ void ExternalMetrics::CollectEventsAndReschedule() {
}
void ExternalMetrics::ScheduleCollector() {
- bool result = BrowserThread::GetBlockingPool()->PostDelayedWorkerTask(
+ base::PostDelayedTaskWithTraits(
FROM_HERE,
- base::Bind(&chromeos::ExternalMetrics::CollectEventsAndReschedule, this),
- base::TimeDelta::FromSeconds(kExternalMetricsCollectionIntervalSeconds));
- DCHECK(result);
+ base::TaskTraits().MayBlock().WithPriority(
+ base::TaskPriority::BACKGROUND),
+ base::BindOnce(&chromeos::ExternalMetrics::CollectEventsAndReschedule,
+ this),
+ kExternalMetricsCollectionInterval);
}
} // namespace chromeos
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698