Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2839943002: Revert of 🔍 Don't display the search engine until First Run completes (Closed)

Created:
3 years, 7 months ago by perezju
Modified:
3 years, 7 months ago
Reviewers:
Ted C, Yusuf, gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of 🔍 Don't display the search engine until First Run completes (patchset #9 id:160001 of https://codereview.chromium.org/2834253002/ ) Reason for revert: Appears to have broken FirstRunIntegrationTest#testClickThroughFirstRun crbug.com/715054 Original issue's description: > 🔍 Don't display the search engine until First Run completes > > * Adds a check to prevent showing branding if First Run hasn't completed. > > * Updates the widget so that it is updated when an AsyncInitializationActivity > subclass calls onDeferredStartup(). > > * Changes the resource for the microphone to match the omnibox's, as well as > uses its content description. > > * Adds tests to confirm that the search engine is updated once First Run > completes. > > BUG=708844, 710952 > > Review-Url: https://codereview.chromium.org/2834253002 > Cr-Commit-Position: refs/heads/master@{#466839} > Committed: https://chromium.googlesource.com/chromium/src/+/ffdac2746296923b2658e9b7fa4a4e6f4ee79184 TBR=tedchoc@chromium.org,yusufo@chromium.org,dfalcantara@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=708844, 710952 Review-Url: https://codereview.chromium.org/2839943002 Cr-Commit-Position: refs/heads/master@{#466946} Committed: https://chromium.googlesource.com/chromium/src/+/387c2f19a653715fc14e8ee857fba3323fa92ba8

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
perezju
Created Revert of 🔍 Don't display the search engine until First Run completes
3 years, 7 months ago (2017-04-25 11:55:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839943002/1
3 years, 7 months ago (2017-04-25 11:55:25 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-04-25 11:56:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/387c2f19a653715fc14e8ee857fb...

Powered by Google App Engine
This is Rietveld 408576698