🔍 Don't display the search engine until First Run completes
* Adds a check to prevent showing branding if First Run hasn't completed.
* Updates the widget so that it is updated when an AsyncInitializationActivity
subclass calls onDeferredStartup().
* Changes the resource for the microphone to match the omnibox's, as well as
uses its content description.
* Adds tests to confirm that the search engine is updated once First Run
completes.
BUG=708844, 710952
Review-Url: https://codereview.chromium.org/2834253002
Cr-Commit-Position: refs/heads/master@{#466839}
Committed: https://chromium.googlesource.com/chromium/src/+/ffdac2746296923b2658e9b7fa4a4e6f4ee79184
3 years, 8 months ago
(2017-04-22 00:57:02 UTC)
#2
Ted C
https://codereview.chromium.org/2834253002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java File chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java (right): https://codereview.chromium.org/2834253002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java#newcode217 chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java:217: mHandler.post(new Runnable() { same question as the other init, ...
3 years, 8 months ago
(2017-04-22 20:17:06 UTC)
#3
Description was changed from ========== 🔍 Don't display the search engine until First Run completes ...
3 years, 8 months ago
(2017-04-23 20:57:41 UTC)
#4
Description was changed from
==========
🔍 Don't display the search engine until First Run completes
* Adds a check to prevent showing branding if First Run hasn't completed.
* Updates the widget so that it is updated when an AsyncInitializationActivity
subclass calls onDeferredStartup().
* Changes the resource for the microphone to match the omnibox's, as well as
uses its content description.
BUG=708844,710952
==========
to
==========
🔍 Don't display the search engine until First Run completes
* Adds a check to prevent showing branding if First Run hasn't completed.
* Updates the widget so that it is updated when an AsyncInitializationActivity
subclass calls onDeferredStartup().
* Changes the resource for the microphone to match the omnibox's, as well as
uses its content description.
* Adds tests to confirm that the search engine is updated once First Run
completes.
BUG=708844,710952
==========
gone
Added some tests to see if this is working correctly. Also started a thread with ...
3 years, 8 months ago
(2017-04-23 21:00:34 UTC)
#5
Added some tests to see if this is working correctly. Also started a thread
with Yoland about how to ensure tests that don't inherit from
ChromeActivityTestCaseBase clean up properly between runs because I've hit that
twice now.
https://codereview.chromium.org/2834253002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java
(right):
https://codereview.chromium.org/2834253002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java:217:
mHandler.post(new Runnable() {
On 2017/04/22 20:17:06, Ted C wrote:
> same question as the other init, do you want this to be per activity or just
> once per process initialization?
>
> If the latter, I think it is better to go in
> ProcessInitializationHandler#handleDeferredStartupTasksInitialization
>
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...
Moved it to when the FirstRunActivity marks itself compelte. I'll need another
check once the the promo dialog is in to force a widget update there.
gone
The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run
3 years, 8 months ago
(2017-04-23 21:00:39 UTC)
#6
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/253621) android_clang_dbg_recipe on ...
3 years, 8 months ago
(2017-04-23 21:04:00 UTC)
#9
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/277962)
3 years, 8 months ago
(2017-04-24 02:45:10 UTC)
#13
https://codereview.chromium.org/2834253002/diff/140001/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java File chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java (right): https://codereview.chromium.org/2834253002/diff/140001/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java#newcode259 chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java:259: String text = TextUtils.isEmpty(engineName) || !shouldShowFullString() On 2017/04/24 21:23:38, ...
3 years, 8 months ago
(2017-04-24 21:36:18 UTC)
#21
https://codereview.chromium.org/2834253002/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java
(right):
https://codereview.chromium.org/2834253002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java:259:
String text = TextUtils.isEmpty(engineName) || !shouldShowFullString()
On 2017/04/24 21:23:38, Ted C wrote:
> is this check necessary? Should we have received an empty value here?
>
> Worth asserting in that case?
I _believe_ it's necessary in the case where Android automatically tells us to
update the widget (currently once per day). It's a fallback to catch cases like
that.
https://codereview.chromium.org/2834253002/diff/140001/chrome/android/javates...
File
chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java
(right):
https://codereview.chromium.org/2834253002/diff/140001/chrome/android/javates...
chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java:209:
@SmallTest
On 2017/04/24 21:23:38, Ted C wrote:
> I'd argue MediumTest at least...a fair amount of clicks and interactions
Done.
https://codereview.chromium.org/2834253002/diff/140001/chrome/android/javates...
chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java:236:
mTestObserver.jumpToPageCallback.waitForCallback(0);
On 2017/04/24 21:23:38, Ted C wrote:
> For all these waitForCallback's, we should use the one that takes a string
param
> to make the failure cases clearer
Done.
gone
The CQ bit was checked by dfalcantara@chromium.org
3 years, 8 months ago
(2017-04-24 21:36:39 UTC)
#22
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/437534)
3 years, 8 months ago
(2017-04-24 22:37:07 UTC)
#26
CQ is committing da patch. Bot data: {"patchset_id": 160001, "attempt_start_ts": 1493078871782210, "parent_rev": "84eea314227407de46fbfde376d082bd41faa438", "commit_rev": "ffdac2746296923b2658e9b7fa4a4e6f4ee79184"}
3 years, 8 months ago
(2017-04-25 00:36:02 UTC)
#29
CQ is committing da patch.
Bot data: {"patchset_id": 160001, "attempt_start_ts": 1493078871782210,
"parent_rev": "84eea314227407de46fbfde376d082bd41faa438", "commit_rev":
"ffdac2746296923b2658e9b7fa4a4e6f4ee79184"}
commit-bot: I haz the power
Description was changed from ========== 🔍 Don't display the search engine until First Run completes ...
3 years, 8 months ago
(2017-04-25 00:36:56 UTC)
#30
Message was sent while issue was closed.
Description was changed from
==========
🔍 Don't display the search engine until First Run completes
* Adds a check to prevent showing branding if First Run hasn't completed.
* Updates the widget so that it is updated when an AsyncInitializationActivity
subclass calls onDeferredStartup().
* Changes the resource for the microphone to match the omnibox's, as well as
uses its content description.
* Adds tests to confirm that the search engine is updated once First Run
completes.
BUG=708844,710952
==========
to
==========
🔍 Don't display the search engine until First Run completes
* Adds a check to prevent showing branding if First Run hasn't completed.
* Updates the widget so that it is updated when an AsyncInitializationActivity
subclass calls onDeferredStartup().
* Changes the resource for the microphone to match the omnibox's, as well as
uses its content description.
* Adds tests to confirm that the search engine is updated once First Run
completes.
BUG=708844,710952
Review-Url: https://codereview.chromium.org/2834253002
Cr-Commit-Position: refs/heads/master@{#466839}
Committed:
https://chromium.googlesource.com/chromium/src/+/ffdac2746296923b2658e9b7fa4a...
==========
commit-bot: I haz the power
Committed patchset #9 (id:160001) as https://chromium.googlesource.com/chromium/src/+/ffdac2746296923b2658e9b7fa4a4e6f4ee79184
3 years, 8 months ago
(2017-04-25 00:36:57 UTC)
#31
Issue 2834253002: 🔍 Don't display the search engine until First Run completes
(Closed)
Created 3 years, 8 months ago by gone
Modified 3 years, 8 months ago
Reviewers: Ted C, Yusuf
Base URL:
Comments: 8