Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2839753004:
Rename WebVR origin trial in conditional features (Closed)
DescriptionRename WebVR origin trial in conditional features
BUG=714775
Review-Url: https://codereview.chromium.org/2839753004
Cr-Commit-Position: refs/heads/master@{#467022}
Committed: https://chromium.googlesource.com/chromium/src/+/67027f74a115a3d139b7ec92f0cc3d4a61fe6917
Patch Set 1 #
Messages
Total messages: 17 (9 generated)
amp@chromium.org changed reviewers: + iclelland@chromium.org, rbyers@chromium.org
amp@chromium.org changed reviewers: + haraken@chromium.org - rbyers@chromium.org
+haraken for blink OWNERS approval.
lgtm
On 2017/04/24 21:24:57, iclelland wrote: > lgtm haraken -- for context, this is a follow-up to https://codereview.chromium.org/2830123002. The changes should have been made together, but it's the first time we've done this since adding the InstallPendingConditionalFeature* functions, so it fell through the cracks.
The CQ bit was checked by amp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/04/24 21:27:45, iclelland wrote: > On 2017/04/24 21:24:57, iclelland wrote: > > lgtm > > haraken -- for context, this is a follow-up to > https://codereview.chromium.org/2830123002. The changes should have been made > together, but it's the first time we've done this since adding the > InstallPendingConditionalFeature* functions, so it fell through the cracks. Ping. We're hoping to merge this back to 59 before it goes to beta on Thursday. So we need to get it in canary to bake asap.
On 2017/04/25 05:04:16, amp wrote: > On 2017/04/24 21:27:45, iclelland wrote: > > On 2017/04/24 21:24:57, iclelland wrote: > > > lgtm > > > > haraken -- for context, this is a follow-up to > > https://codereview.chromium.org/2830123002. The changes should have been made > > together, but it's the first time we've done this since adding the > > InstallPendingConditionalFeature* functions, so it fell through the cracks. > > Ping. We're hoping to merge this back to 59 before it goes to beta on Thursday. > So we need to get it in canary to bake asap. LGTM (sorry, I was travelling.)
The CQ bit was checked by amp@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493139777613100, "parent_rev":
"87356e8607d5c60651e22ab2ed406cfc99b512b5", "commit_rev":
"67027f74a115a3d139b7ec92f0cc3d4a61fe6917"}
Message was sent while issue was closed.
Description was changed from ========== Rename WebVR origin trial in conditional features BUG=714775 ========== to ========== Rename WebVR origin trial in conditional features BUG=714775 Review-Url: https://codereview.chromium.org/2839753004 Cr-Commit-Position: refs/heads/master@{#467022} Committed: https://chromium.googlesource.com/chromium/src/+/67027f74a115a3d139b7ec92f0cc... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/67027f74a115a3d139b7ec92f0cc... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
