|
|
Chromium Code Reviews
DescriptionRename WebVR origin trial
BUG=713853
Review-Url: https://codereview.chromium.org/2830123002
Cr-Commit-Position: refs/heads/master@{#466541}
Committed: https://chromium.googlesource.com/chromium/src/+/94561434e49d009b34dd000575f14537802ec6aa
Patch Set 1 #Patch Set 2 : rebase #
Messages
Total messages: 20 (13 generated)
amp@chromium.org changed reviewers: + bajones@chromium.org, rbyers@chromium.org
I'm not sure if '.' is allowed in the name. If not we'll come up with something else. This is for a 1.1 version of the spec so I didn't want to jump up to '2' in the name.
On 2017/04/20 20:20:09, amp wrote: > I'm not sure if '.' is allowed in the name. If not we'll come up with something > else. > > This is for a 1.1 version of the spec so I didn't want to jump up to '2' in the > name. The origin trials framework doesn't put any specific character restrictions on trial names. I ran a quick test using generate_token.py/check_token.py, and the name of 'WebVR1.1' worked fine, as I expected. Should test in Chrome to be sure, but I think this will be fine.
On 2017/04/20 20:46:47, chasej wrote: > On 2017/04/20 20:20:09, amp wrote: > > I'm not sure if '.' is allowed in the name. If not we'll come up with > something > > else. > > > > This is for a 1.1 version of the spec so I didn't want to jump up to '2' in > the > > name. > > The origin trials framework doesn't put any specific character restrictions on > trial names. I ran a quick test using generate_token.py/check_token.py, and the > name of 'WebVR1.1' worked fine, as I expected. Should test in Chrome to be sure, > but I think this will be fine. LGTM then, thanks for checking!
The CQ bit was checked by amp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by amp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Friendly ping to rbyers@ for owners approval.
Sorry for the delay (traveling). LGTM For future reference any platform OWNER will do for RuntimeEnabledFeatures changes, you don't need an API OWNER for that (only any virtual/stable/webexposed test results).
The CQ bit was checked by amp@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bajones@chromium.org Link to the patchset: https://codereview.chromium.org/2830123002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492873730168080,
"parent_rev": "150a0a9177dc26b6ebbe66f909c0860a49bfb6e1", "commit_rev":
"94561434e49d009b34dd000575f14537802ec6aa"}
Message was sent while issue was closed.
Description was changed from ========== Rename WebVR origin trial BUG=713853 ========== to ========== Rename WebVR origin trial BUG=713853 Review-Url: https://codereview.chromium.org/2830123002 Cr-Commit-Position: refs/heads/master@{#466541} Committed: https://chromium.googlesource.com/chromium/src/+/94561434e49d009b34dd000575f1... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/94561434e49d009b34dd000575f1... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
