Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1783)

Unified Diff: cc/trees/layer_tree_host_impl_unittest.cc

Issue 2839533002: Remove Layer/LayerImpl's FixedContainerSizeDelta (Closed)
Patch Set: Remove FixedContainerSizeDelta Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/layer_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_impl_unittest.cc
diff --git a/cc/trees/layer_tree_host_impl_unittest.cc b/cc/trees/layer_tree_host_impl_unittest.cc
index 74f2ab28dafea05983ca4db406eeef6c434e2fe6..6ee185cb7afb6cbb2cebcbfcfee1c13137bba353 100644
--- a/cc/trees/layer_tree_host_impl_unittest.cc
+++ b/cc/trees/layer_tree_host_impl_unittest.cc
@@ -4444,12 +4444,10 @@ TEST_F(LayerTreeHostImplBrowserControlsTest,
host_impl_->browser_controls_manager()->ScrollBy(top_controls_scroll_delta);
host_impl_->browser_controls_manager()->ScrollEnd();
- LayerImpl* inner_viewport_scroll_layer =
- host_impl_->active_tree()->InnerViewportScrollLayer();
- DCHECK(inner_viewport_scroll_layer);
host_impl_->ScrollEnd(EndState().get());
+ auto* property_trees = host_impl_->active_tree()->property_trees();
EXPECT_FLOAT_EQ(top_controls_scroll_delta.y(),
- inner_viewport_scroll_layer->FixedContainerSizeDelta().y());
+ property_trees->inner_viewport_container_bounds_delta().y());
}
// In this test, the outer viewport is initially unscrollable. We test that a
@@ -4550,9 +4548,6 @@ TEST_F(LayerTreeHostImplBrowserControlsTest, FixedContainerDelta) {
host_impl_->active_tree()->PushPageScaleFromMainThread(1.f, 1.f, 2.f);
float page_scale = 1.5f;
- LayerImpl* outer_viewport_scroll_layer =
- host_impl_->active_tree()->OuterViewportScrollLayer();
-
// Zoom in, since the fixed container is the outer viewport, the delta should
// not be scaled.
host_impl_->active_tree()->PushPageScaleFromMainThread(page_scale, 1.f, 2.f);
@@ -4570,8 +4565,10 @@ TEST_F(LayerTreeHostImplBrowserControlsTest, FixedContainerDelta) {
host_impl_->browser_controls_manager()->ScrollBy(top_controls_scroll_delta);
EXPECT_FLOAT_EQ(top_controls_height_ - top_controls_scroll_delta.y(),
host_impl_->browser_controls_manager()->ContentTopOffset());
+
+ auto* property_trees = host_impl_->active_tree()->property_trees();
EXPECT_FLOAT_EQ(top_controls_scroll_delta.y(),
- outer_viewport_scroll_layer->FixedContainerSizeDelta().y());
+ property_trees->outer_viewport_container_bounds_delta().y());
host_impl_->ScrollEnd(EndState().get());
// Scroll past the maximum extent. The delta shouldn't be greater than the
@@ -4582,7 +4579,7 @@ TEST_F(LayerTreeHostImplBrowserControlsTest, FixedContainerDelta) {
host_impl_->browser_controls_manager()->ScrollBy(top_controls_scroll_delta);
EXPECT_EQ(0.f, host_impl_->browser_controls_manager()->ContentTopOffset());
EXPECT_VECTOR_EQ(gfx::Vector2dF(0, top_controls_height_),
- outer_viewport_scroll_layer->FixedContainerSizeDelta());
+ property_trees->outer_viewport_container_bounds_delta());
host_impl_->ScrollEnd(EndState().get());
// Scroll in the direction to make the browser controls show.
@@ -4592,7 +4589,7 @@ TEST_F(LayerTreeHostImplBrowserControlsTest, FixedContainerDelta) {
host_impl_->browser_controls_manager()->ContentTopOffset());
EXPECT_VECTOR_EQ(
gfx::Vector2dF(0, top_controls_height_ - top_controls_scroll_delta.y()),
- outer_viewport_scroll_layer->FixedContainerSizeDelta());
+ property_trees->outer_viewport_container_bounds_delta());
host_impl_->browser_controls_manager()->ScrollEnd();
}
« no previous file with comments | « cc/layers/layer_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698