Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2839403002: Reland of Don't allow a widget to send close notifications more than once. (Closed)

Created:
3 years, 8 months ago by Evan Stade
Modified:
3 years, 8 months ago
Reviewers:
alph, sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Don't allow a widget to send close notifications more than once. (patchset #1 id:1 of https://codereview.chromium.org/2844933002/ ) Reason for revert: We will disable the failing test on Mac. Original issue's description: > Revert of Don't allow a widget to send close notifications more than once. (patchset #3 id:40001 of https://codereview.chromium.org/2834943002/ ) > > Reason for revert: > The enabled WidgetObserverTest.ActivationChange test seems to be flaky > > https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/17210 > > Original issue's description: > > Don't allow a widget to send close notifications more than once. > > > > Add a test to make sure this works. Also fix a couple WidgetTests that > > were disabled. > > > > BUG=714334 > > > > Review-Url: https://codereview.chromium.org/2834943002 > > Cr-Commit-Position: refs/heads/master@{#467171} > > Committed: https://chromium.googlesource.com/chromium/src/+/bf25b17bd99b5dbeff92e62f8dddd289c335dc0a > > TBR=sky@chromium.org,estade@chromium.org > NOTRY=true > BUG=714334 > > Review-Url: https://codereview.chromium.org/2844933002 > Cr-Commit-Position: refs/heads/master@{#467528} > Committed: https://chromium.googlesource.com/chromium/src/+/efd8268f95f1c7a212e5b6edd521761dd8a00e31 TBR=sky@chromium.org,alph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=714334 Review-Url: https://codereview.chromium.org/2839403002 Cr-Commit-Position: refs/heads/master@{#467544} Committed: https://chromium.googlesource.com/chromium/src/+/3a303320be089d790c88890ffc28617415238c5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -38 lines) Patch
M ui/views/widget/widget.cc View 1 chunk +20 lines, -20 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 4 chunks +81 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Evan Stade
Created Reland of Don't allow a widget to send close notifications more than once.
3 years, 8 months ago (2017-04-27 01:49:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839403002/1
3 years, 8 months ago (2017-04-27 01:49:42 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-27 01:50:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3a303320be089d790c88890ffc28...

Powered by Google App Engine
This is Rietveld 408576698