Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2844933002: Revert of Don't allow a widget to send close notifications more than once. (Closed)

Created:
3 years, 8 months ago by alph
Modified:
3 years, 8 months ago
Reviewers:
sky, Evan Stade
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't allow a widget to send close notifications more than once. (patchset #3 id:40001 of https://codereview.chromium.org/2834943002/ ) Reason for revert: The enabled WidgetObserverTest.ActivationChange test seems to be flaky https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/17210 Original issue's description: > Don't allow a widget to send close notifications more than once. > > Add a test to make sure this works. Also fix a couple WidgetTests that > were disabled. > > BUG=714334 > > Review-Url: https://codereview.chromium.org/2834943002 > Cr-Commit-Position: refs/heads/master@{#467171} > Committed: https://chromium.googlesource.com/chromium/src/+/bf25b17bd99b5dbeff92e62f8dddd289c335dc0a TBR=sky@chromium.org,estade@chromium.org NOTRY=true BUG=714334 Review-Url: https://codereview.chromium.org/2844933002 Cr-Commit-Position: refs/heads/master@{#467528} Committed: https://chromium.googlesource.com/chromium/src/+/efd8268f95f1c7a212e5b6edd521761dd8a00e31

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -101 lines) Patch
M ui/views/widget/widget.cc View 1 chunk +20 lines, -20 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 4 chunks +18 lines, -81 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
alph
Created Revert of Don't allow a widget to send close notifications more than once.
3 years, 8 months ago (2017-04-27 00:18:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844933002/1
3 years, 8 months ago (2017-04-27 00:19:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/efd8268f95f1c7a212e5b6edd521761dd8a00e31
3 years, 8 months ago (2017-04-27 00:33:38 UTC) #8
Evan Stade
3 years, 8 months ago (2017-04-27 01:49:04 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2839403002/ by estade@chromium.org.

The reason for reverting is: We will disable the failing test on Mac..

Powered by Google App Engine
This is Rietveld 408576698