Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 2839323002: Revert of printing::Metafile: Simplify OS_MACOSX-specific code path (Closed)

Created:
3 years, 8 months ago by Lei Zhang
Modified:
3 years, 8 months ago
Reviewers:
hal.canary
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of printing::Metafile: Simplify OS_MACOSX-specific code path (patchset #3 id:40001 of https://codereview.chromium.org/2802093006/ ) Reason for revert: Likely causing https://crbug.com/712309 Original issue's description: > printing::Metafile: Simplify OS_MACOSX-specific code path > > - printing::Metafile > * move MacRenderPageParams to PdfMetafileCg > * remove virtual RenderPage() > - printing::PdfMetafileCg > * Add MacRenderPageParams > * RenderPage no longer an override > - printing::PdfMetafileSkia > * no longer implment RenderPage() > * code moved to printing::PrintedDocument::RenderPrintedPage() > > This will help isolate BUG=chromium:374359 > > R=thestig@chromium.org > > Review-Url: https://codereview.chromium.org/2802093006 > Cr-Commit-Position: refs/heads/master@{#463828} > Committed: https://chromium.googlesource.com/chromium/src/+/c843c89f3051e4b01cf032e52c478000f7ded0ee TBR=halcanary@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2839323002 Cr-Commit-Position: refs/heads/master@{#467568} Committed: https://chromium.googlesource.com/chromium/src/+/99fc21391b7a9d2196f567bae881bf8741f31e5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -66 lines) Patch
M printing/image_mac.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M printing/metafile.h View 3 chunks +43 lines, -0 lines 0 comments Download
M printing/pdf_metafile_cg_mac.h View 1 chunk +4 lines, -32 lines 0 comments Download
M printing/pdf_metafile_cg_mac.cc View 1 chunk +3 lines, -16 lines 0 comments Download
M printing/pdf_metafile_skia.h View 1 chunk +5 lines, -0 lines 0 comments Download
M printing/pdf_metafile_skia.cc View 3 chunks +36 lines, -0 lines 0 comments Download
M printing/printed_document_mac.cc View 2 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Lei Zhang
Created Revert of printing::Metafile: Simplify OS_MACOSX-specific code path
3 years, 8 months ago (2017-04-26 22:21:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839323002/1
3 years, 8 months ago (2017-04-26 22:21:59 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/280697)
3 years, 8 months ago (2017-04-27 01:33:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839323002/1
3 years, 8 months ago (2017-04-27 01:45:47 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-27 03:38:31 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/99fc21391b7a9d2196f567bae881...

Powered by Google App Engine
This is Rietveld 408576698