Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: printing/pdf_metafile_cg_mac.cc

Issue 2839323002: Revert of printing::Metafile: Simplify OS_MACOSX-specific code path (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « printing/pdf_metafile_cg_mac.h ('k') | printing/pdf_metafile_skia.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "printing/pdf_metafile_cg_mac.h" 5 #include "printing/pdf_metafile_cg_mac.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 10
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 LOG(ERROR) << "Metafile context has " << extra_retain_count 150 LOG(ERROR) << "Metafile context has " << extra_retain_count
151 << " extra retain(s) on Close"; 151 << " extra retain(s) on Close";
152 } 152 }
153 } 153 }
154 #endif 154 #endif
155 CGPDFContextClose(context_.get()); 155 CGPDFContextClose(context_.get());
156 context_.reset(); 156 context_.reset();
157 return true; 157 return true;
158 } 158 }
159 159
160 /* TODO(caryclark): The set up of PluginInstance::PrintPDFOutput may result in 160 bool PdfMetafileCg::RenderPage(unsigned int page_number,
161 rasterized output. Even if that flow uses PdfMetafileCg::RenderPage,
162 the drawing of the PDF into the canvas may result in a rasterized output.
163 PDFMetafileSkia::RenderPage should be not implemented as shown and instead
164 should do something like the following CL in PluginInstance::PrintPDFOutput:
165 http://codereview.chromium.org/7200040/diff/1/webkit/plugins/ppapi/ppapi_plug in_instance.cc
166 */
167 bool PdfMetafileCg::RenderPage(const std::vector<char>& src_buffer,
168 unsigned int page_number,
169 CGContextRef context, 161 CGContextRef context,
170 const CGRect rect, 162 const CGRect rect,
171 const PdfMetafileCg::RenderPageParams& params) { 163 const MacRenderPageParams& params) const {
172 PdfMetafileCg metafile; 164 CGPDFDocumentRef pdf_doc = GetPDFDocument();
173 if (!metafile.InitFromData(src_buffer.data(), src_buffer.size())) {
174 LOG(ERROR) << "Unable to initialize PDF document from data";
175 return false;
176 }
177 CGPDFDocumentRef pdf_doc = metafile.GetPDFDocument();
178 if (!pdf_doc) { 165 if (!pdf_doc) {
179 LOG(ERROR) << "Unable to create PDF document from data"; 166 LOG(ERROR) << "Unable to create PDF document from data";
180 return false; 167 return false;
181 } 168 }
182 CGPDFPageRef pdf_page = CGPDFDocumentGetPage(pdf_doc, page_number); 169 CGPDFPageRef pdf_page = CGPDFDocumentGetPage(pdf_doc, page_number);
183 CGRect source_rect = CGPDFPageGetBoxRect(pdf_page, kCGPDFCropBox); 170 CGRect source_rect = CGPDFPageGetBoxRect(pdf_page, kCGPDFCropBox);
184 int pdf_src_rotation = CGPDFPageGetRotationAngle(pdf_page); 171 int pdf_src_rotation = CGPDFPageGetRotationAngle(pdf_page);
185 float scaling_factor = 1.0; 172 float scaling_factor = 1.0;
186 const bool source_is_landscape = 173 const bool source_is_landscape =
187 (source_rect.size.width > source_rect.size.height); 174 (source_rect.size.width > source_rect.size.height);
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
305 292
306 if (!pdf_doc_.get()) { 293 if (!pdf_doc_.get()) {
307 ScopedCFTypeRef<CGDataProviderRef> pdf_data_provider( 294 ScopedCFTypeRef<CGDataProviderRef> pdf_data_provider(
308 CGDataProviderCreateWithCFData(pdf_data_)); 295 CGDataProviderCreateWithCFData(pdf_data_));
309 pdf_doc_.reset(CGPDFDocumentCreateWithProvider(pdf_data_provider)); 296 pdf_doc_.reset(CGPDFDocumentCreateWithProvider(pdf_data_provider));
310 } 297 }
311 return pdf_doc_.get(); 298 return pdf_doc_.get();
312 } 299 }
313 300
314 } // namespace printing 301 } // namespace printing
OLDNEW
« no previous file with comments | « printing/pdf_metafile_cg_mac.h ('k') | printing/pdf_metafile_skia.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698