Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2839253002: ❄ Introduce header and footer logic to search engine promos (Closed)

Created:
3 years, 8 months ago by gone
Modified:
3 years, 8 months ago
Reviewers:
Theresa
CC:
chromium-reviews, dfalcantara+watch_chromium.org, agrieve+watch_chromium.org, Ted C
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

❄ Introduce header and footer logic to search engine promos * Add the ability to PromoDialog to be able to keep a header and footer fixed while the contents are scrollable. Scrollable content is indicated by a never disappearing scrollbar indicator. * Adds the ability to add a InfoBarControlLayout to the PromoDialogLayout. This is used to standardize the buttons that are displayed across dialogs. * Add the ability to add tags to the InfoBarControlLayout radio buttons. These are needed because IDs aren't set for the radio buttons, and because it is safer to keep track of the search engine keywords with the RadioButtons that represent them. Things to do: - InfoBarControlLayout needs to move to the widget/ directory and be generalized so that they're not so infobar specific. - Tests are in a separate CL. Example screenshots: https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDRmlnZ1g0LXVpMGM BUG=714223, 712836, 712833 Review-Url: https://codereview.chromium.org/2839253002 Cr-Commit-Position: refs/heads/master@{#467488} Committed: https://chromium.googlesource.com/chromium/src/+/1046c549109b2dfdcf18b6f2336460f14daf88d3

Patch Set 1 #

Patch Set 2 : Pulling out #

Patch Set 3 : 🔍 Introduce header and footer logic to search engine promos #

Patch Set 4 : 🔍 Introduce header and footer logic to search engine promos #

Messages

Total messages: 16 (12 generated)
gone
Yanked this out of another CL because it was becoming a hot mess. PTAL.
3 years, 8 months ago (2017-04-26 19:25:21 UTC) #3
Theresa
lgtm crbug.com/618824 and crbug.com/616535 for scrolling dialogs
3 years, 8 months ago (2017-04-26 21:04:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839253002/60001
3 years, 8 months ago (2017-04-26 21:06:46 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 22:41:50 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1046c549109b2dfdcf18b6f23364...

Powered by Google App Engine
This is Rietveld 408576698