Chromium Code Reviews
Description❄ Introduce header and footer logic to search engine promos
* Add the ability to PromoDialog to be able to keep a header and footer fixed
while the contents are scrollable. Scrollable content is indicated by a never
disappearing scrollbar indicator.
* Adds the ability to add a InfoBarControlLayout to the PromoDialogLayout. This
is used to standardize the buttons that are displayed across dialogs.
* Add the ability to add tags to the InfoBarControlLayout radio buttons. These
are needed because IDs aren't set for the radio buttons, and because it is
safer to keep track of the search engine keywords with the RadioButtons that
represent them.
Things to do:
- InfoBarControlLayout needs to move to the widget/ directory and be generalized
so that they're not so infobar specific.
- Tests are in a separate CL.
Example screenshots:
https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDRmlnZ1g0LXVpMGM
BUG=714223, 712836, 712833
Review-Url: https://codereview.chromium.org/2839253002
Cr-Commit-Position: refs/heads/master@{#467488}
Committed: https://chromium.googlesource.com/chromium/src/+/1046c549109b2dfdcf18b6f2336460f14daf88d3
Patch Set 1 #Patch Set 2 : Pulling out #Patch Set 3 : 🔍 Introduce header and footer logic to search engine promos #Patch Set 4 : 🔍 Introduce header and footer logic to search engine promos #Dependent Patchsets: Messages
Total messages: 16 (12 generated)
|