Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issue 2839153002: Revert of headless: Add support for net logging (Closed)

Created:
2 years, 1 month ago by findit-for-me
Modified:
2 years, 1 month ago
Reviewers:
vitaliii, Eric Seckler, Sami
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of headless: Add support for net logging (patchset #2 id:20001 of https://codereview.chromium.org/2841953002/ ) Reason for revert: Findit(https://goo.gl/kROfz5) identified CL at revision 467289 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I5YTQyYWI2ZjA3M2IwNTdjOGMwNWQyYmZjNzk5ZGNjODA4MmUyYTYM Sheriff's note: See crbug.com/715513 for details. Original issue's description: > headless: Add support for net logging > > This patch adds support for the --log-net-log command line flag to > headless to help diagnosing issues with networking. > > BUG=706355 > > Review-Url: https://codereview.chromium.org/2841953002 > Cr-Commit-Position: refs/heads/master@{#467289} > Committed: https://chromium.googlesource.com/chromium/src/+/b9a42ab6f073b057c8c05d2bfc799dcc8082e2a6 TBR=eseckler@chromium.org,skyostil@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=706355, 715513 Review-Url: https://codereview.chromium.org/2839153002 Cr-Commit-Position: refs/heads/master@{#467297} Committed: https://chromium.googlesource.com/chromium/src/+/7615988083fac48fe5410bb59a9e379853615aa8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -179 lines) Patch
M headless/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M headless/lib/browser/headless_browser_context_impl.cc View 2 chunks +1 line, -4 lines 0 comments Download
M headless/lib/browser/headless_browser_main_parts.h View 2 chunks +0 lines, -5 lines 0 comments Download
M headless/lib/browser/headless_browser_main_parts.cc View 2 chunks +0 lines, -11 lines 0 comments Download
D headless/lib/browser/headless_net_log.h View 1 chunk +0 lines, -33 lines 0 comments Download
D headless/lib/browser/headless_net_log.cc View 1 chunk +0 lines, -75 lines 0 comments Download
M headless/lib/browser/headless_url_request_context_getter.h View 2 chunks +1 line, -3 lines 0 comments Download
M headless/lib/browser/headless_url_request_context_getter.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M headless/lib/headless_browser_browsertest.cc View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
findit-for-me
Created Revert of headless: Add support for net logging
2 years, 1 month ago (2017-04-26 11:13:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839153002/1
2 years, 1 month ago (2017-04-26 11:38:58 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
2 years, 1 month ago (2017-04-26 11:39:00 UTC) #6
vitaliii
LGTM.
2 years, 1 month ago (2017-04-26 11:39:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839153002/1
2 years, 1 month ago (2017-04-26 11:40:15 UTC) #9
commit-bot: I haz the power
2 years, 1 month ago (2017-04-26 11:40:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7615988083fac48fe5410bb59a9e...

Powered by Google App Engine
This is Rietveld 408576698