headless: Add support for net logging

headless: Add support for net logging

This patch adds support for the --log-net-log command line flag to
headless to help diagnosing issues with networking.

BUG=706355
Review-Url: https://codereview.chromium.org/2841953002
Review-Url: https://codereview.chromium.org/2841953002
Cr-Commit-Position: refs/heads/master@{#467315}
Committed: https://chromium.googlesource.com/chromium/src/+/86195291fae07e5bb665295e0cb598777100ff34

[Sami, 2017-04-25 16:40:53]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[Sami, 2017-04-25 16:41:03]

Description was changed from

==========
headless: Add support for net logging

This patch adds support for the --log-net-log command line flag to
headless to help diagnosing issues with networking.

BUG=706355
==========

to

==========
headless: Add support for net logging

This patch adds support for the --log-net-log command line flag to
headless to help diagnosing issues with networking.

BUG=706355
==========

[Sami, 2017-04-25 16:41:03]

skyostil@chromium.org changed reviewers:
+ eseckler@chromium.org

[commit-bot: I haz the power, 2017-04-25 16:41:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Seckler, 2017-04-25 16:59:33]

lgtm! But somehow the headless bot doesn't seem happy about the thread
restrictions still:

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux...

[Eric Seckler, 2017-04-25 17:00:51]

https://codereview.chromium.org/2841953002/diff/1/headless/lib/headless_brows...
File headless/lib/headless_browser_browsertest.cc (right):

https://codereview.chromium.org/2841953002/diff/1/headless/lib/headless_brows...
headless/lib/headless_browser_browsertest.cc:796: void SetUp() override {
Maybe SetUp() can be called on a different thread than the actual test
execution? That sounds a bit weird though.

[commit-bot: I haz the power, 2017-04-25 18:20:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 18:20:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sami, 2017-04-25 18:22:31]

Thanks!

https://codereview.chromium.org/2841953002/diff/1/headless/lib/headless_brows...
File headless/lib/headless_browser_browsertest.cc (right):

https://codereview.chromium.org/2841953002/diff/1/headless/lib/headless_brows...
headless/lib/headless_browser_browsertest.cc:796: void SetUp() override {
On 2017/04/25 17:00:51, Eric Seckler wrote:
> Maybe SetUp() can be called on a different thread than the actual test
> execution? That sounds a bit weird though.

I think it's more likely that something else resets the IO restrictions at some
point and we're hitting that. I've just reset them here in the test again.

[Sami, 2017-04-25 18:22:36]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2017-04-25 18:22:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
eseckler@chromium.org
Link to the patchset: https://codereview.chromium.org/2841953002/#ps20001
(title: "Allow IO in test")

[commit-bot: I haz the power, 2017-04-25 18:23:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 19:11:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 19:11:30]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sami, 2017-04-26 09:54:57]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2017-04-26 09:55:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 10:32:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493200497141320,
"parent_rev": "07fefc1ec0552e64747b0688b2598649375016bc", "commit_rev":
"b9a42ab6f073b057c8c05d2bfc799dcc8082e2a6"}

[commit-bot: I haz the power, 2017-04-26 10:32:18]

Description was changed from

==========
headless: Add support for net logging

This patch adds support for the --log-net-log command line flag to
headless to help diagnosing issues with networking.

BUG=706355
==========

to

==========
headless: Add support for net logging

This patch adds support for the --log-net-log command line flag to
headless to help diagnosing issues with networking.

BUG=706355

Review-Url: https://codereview.chromium.org/2841953002
Cr-Commit-Position: refs/heads/master@{#467289}
Committed:
https://chromium.googlesource.com/chromium/src/+/b9a42ab6f073b057c8c05d2bfc79...
==========

[commit-bot: I haz the power, 2017-04-26 10:32:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b9a42ab6f073b057c8c05d2bfc79...

[findit-for-me, 2017-04-26 11:13:24]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2839153002/ by
findit-for-me@appspot.gserviceaccount.com.

The reason for reverting is: 
Findit(https://goo.gl/kROfz5) identified CL at revision 467289 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb....

[Sami, 2017-04-26 12:57:24]

Description was changed from

==========
headless: Add support for net logging

This patch adds support for the --log-net-log command line flag to
headless to help diagnosing issues with networking.

BUG=706355

Review-Url: https://codereview.chromium.org/2841953002
Cr-Commit-Position: refs/heads/master@{#467289}
Committed:
https://chromium.googlesource.com/chromium/src/+/b9a42ab6f073b057c8c05d2bfc79...
==========

to

==========
headless: Add support for net logging

This patch adds support for the --log-net-log command line flag to
headless to help diagnosing issues with networking.

BUG=706355

Review-Url: https://codereview.chromium.org/2841953002
Cr-Commit-Position: refs/heads/master@{#467289}
Committed:
https://chromium.googlesource.com/chromium/src/+/b9a42ab6f073b057c8c05d2bfc79...
==========

[Sami, 2017-04-26 12:57:34]

Description was changed from

==========
headless: Add support for net logging

This patch adds support for the --log-net-log command line flag to
headless to help diagnosing issues with networking.

BUG=706355

Review-Url: https://codereview.chromium.org/2841953002
Cr-Commit-Position: refs/heads/master@{#467289}
Committed:
https://chromium.googlesource.com/chromium/src/+/b9a42ab6f073b057c8c05d2bfc79...
==========

to

==========
headless: Add support for net logging

This patch adds support for the --log-net-log command line flag to
headless to help diagnosing issues with networking.

BUG=706355

Review-Url: https://codereview.chromium.org/2841953002
==========

[Sami, 2017-04-26 12:57:40]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2017-04-26 12:57:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
eseckler@chromium.org
Link to the patchset: https://codereview.chromium.org/2841953002/#ps40001
(title: "CrOS build fix")

[commit-bot: I haz the power, 2017-04-26 12:57:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 14:08:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493211460936390,
"parent_rev": "e0d2b32a6aacfbc5a84d465f05cc1c953fd7d056", "commit_rev":
"86195291fae07e5bb665295e0cb598777100ff34"}

[commit-bot: I haz the power, 2017-04-26 14:08:15]

Description was changed from

==========
headless: Add support for net logging

This patch adds support for the --log-net-log command line flag to
headless to help diagnosing issues with networking.

BUG=706355

Review-Url: https://codereview.chromium.org/2841953002
==========

to

==========
headless: Add support for net logging

This patch adds support for the --log-net-log command line flag to
headless to help diagnosing issues with networking.

BUG=706355

Review-Url: https://codereview.chromium.org/2841953002
Review-Url: https://codereview.chromium.org/2841953002
Cr-Commit-Position: refs/heads/master@{#467315}
Committed:
https://chromium.googlesource.com/chromium/src/+/86195291fae07e5bb665295e0cb5...
==========

[commit-bot: I haz the power, 2017-04-26 14:08:16]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/86195291fae07e5bb665295e0cb5...