[Autofill] UKM for suggestions polled field.

components/autofill/core/browser/autofill_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
 
 #include <deque>
 #include <map>
 #include <memory>
@@ skipping 42 matching lines @@
 
 namespace autofill {
 
 class AutofillDataModel;
 class AutofillDownloadManager;
 class AutofillExternalDelegate;
 class AutofillField;
 class AutofillClient;
 class AutofillManagerTestDelegate;
 class AutofillProfile;
-class AutofillType;
 class CreditCard;
 class FormStructureBrowserTest;
 
 struct FormData;
 struct FormFieldData;
 
 // We show the credit card signin promo only a certain number of times.
 extern const int kCreditCardSigninPromoImpressionLimit;
 
 // Manages saving and restoring the user's personal information entered into web
@@ skipping 322 matching lines @@
       WARN_UNUSED_RESULT;
 
   // Re-parses |live_form| and adds the result to |form_structures_|.
   // |cached_form| should be a pointer to the existing version of the form, or
   // NULL if no cached version exists.  The updated form is then written into
   // |updated_form|.  Returns false if the cache could not be updated.
   bool UpdateCachedForm(const FormData& live_form,
                         const FormStructure* cached_form,
                         FormStructure** updated_form) WARN_UNUSED_RESULT;
 
-  // Returns a list of values from the stored profiles that match |type| and the
-  // value of |field| and returns the labels of the matching profiles. |labels|
-  // is filled with the Profile label.
+  // Returns a list of values from the stored profiles that match field type
+  // |autofill_field.Type()| and the value of |field| and returns the labels of

[csashi, 2017/04/27 18:41:17]

Reorder as
"that match the value of |field| and match field type |autofill_field.Type()| to
align with order of parameters?

[jiahuiguo, 2017/05/24 18:00:00]

Moved the ukm from pollsuggestions to suggestionsShown.

+  // the matching profiles. |labels| is filled with the Profile label.
   std::vector<Suggestion> GetProfileSuggestions(
       const FormStructure& form,
       const FormFieldData& field,
       const AutofillField& autofill_field) const;
 
-  // Returns a list of values from the stored credit cards that match |type| and
-  // the value of |field| and returns the labels of the matching credit cards.
+  // Returns a list of values from the stored credit cards that match field type
+  // |autofill_field.Type()| and the value of |field| and returns the labels of
+  // the matching credit cards.

[csashi, 2017/04/27 18:41:17]

Same comment.

[jiahuiguo, 2017/05/24 18:00:00]

Acknowledged.

   std::vector<Suggestion> GetCreditCardSuggestions(
       const FormFieldData& field,
-      const AutofillType& type) const;
+      const AutofillField& autofill_field) const;
 
   // Parses the forms using heuristic matching and querying the Autofill server.
   void ParseForms(const std::vector<FormData>& forms);
 
   // Parses the form and adds it to |form_structures_|.
   bool ParseForm(const FormData& form, FormStructure** parsed_form_structure);
 
   // Imports the form data, submitted by the user, into |personal_data_|.
   void ImportFormData(const FormStructure& submitted_form);
 
@@ skipping 206 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
                            OnLoadedServerPredictions_ResetManager);
   FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, DontOfferToSavePaymentsCard);
   FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, FillInUpdatedExpirationDate);
   DISALLOW_COPY_AND_ASSIGN(AutofillManager);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_