Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2839023004: Revert of Revert "[wrapper-tracing] Bail out tracing for empty handles" (Closed)

Created:
3 years, 7 months ago by alancutter (OOO until 2018)
Modified:
3 years, 7 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert "[wrapper-tracing] Bail out tracing for empty handles" (patchset #1 id:1 of https://codereview.chromium.org/2840013003/ ) Reason for revert: This revert breaks compile: ../../third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp:262:8: error: use of undeclared identifier 'm_tracingInProgress'; did you mean 'tracing_in_progress_'? if (!m_tracingInProgress) ^~~~~~~~~~~~~~~~~~~ tracing_in_progress_ ../../third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h:194:8: note: 'tracing_in_progress_' declared here bool tracing_in_progress_ = false; ^ 1 error generated. Original issue's description: > Revert "[wrapper-tracing] Bail out tracing for empty handles" > > This reverts commit fc1c3f831aeceee5e63501e8c700003fc1802b2b. > > TBR=mlippautz@chrommium.org > NOTRY=true > > Review-Url: https://codereview.chromium.org/2840013003 > Cr-Commit-Position: refs/heads/master@{#467214} > Committed: https://chromium.googlesource.com/chromium/src/+/79f22e60f857a83a592216c33a47035268c2cda7 TBR=haraken@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2839023004 Cr-Commit-Position: refs/heads/master@{#467218} Committed: https://chromium.googlesource.com/chromium/src/+/84d4dfb32ea85d528373295087f10d0766d556b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
alancutter (OOO until 2018)
Created Revert of Revert "[wrapper-tracing] Bail out tracing for empty handles"
3 years, 7 months ago (2017-04-26 03:04:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839023004/1
3 years, 7 months ago (2017-04-26 03:05:11 UTC) #3
haraken
LGTM, thanks for the revert!
3 years, 7 months ago (2017-04-26 03:05:44 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-04-26 03:06:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/84d4dfb32ea85d528373295087f1...

Powered by Google App Engine
This is Rietveld 408576698