Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2840013003: Revert "[wrapper-tracing] Bail out tracing for empty handles" (Closed)

Created:
3 years, 8 months ago by haraken
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "[wrapper-tracing] Bail out tracing for empty handles" This reverts commit fc1c3f831aeceee5e63501e8c700003fc1802b2b. TBR=mlippautz@chrommium.org NOTRY=true Review-Url: https://codereview.chromium.org/2840013003 Cr-Commit-Position: refs/heads/master@{#467214} Committed: https://chromium.googlesource.com/chromium/src/+/79f22e60f857a83a592216c33a47035268c2cda7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
haraken
I merged this CL to a wrong branch (3010). So reverting it. Sorry about the ...
3 years, 8 months ago (2017-04-26 02:48:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840013003/1
3 years, 8 months ago (2017-04-26 02:49:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/79f22e60f857a83a592216c33a47035268c2cda7
3 years, 8 months ago (2017-04-26 02:54:02 UTC) #8
alancutter (OOO until 2018)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2839023004/ by alancutter@chromium.org. ...
3 years, 8 months ago (2017-04-26 03:04:38 UTC) #9
findit-for-me
Findit(https://goo.gl/kROfz5) confirmed this CL at revision 467214 as the culprit for failures in the build ...
3 years, 8 months ago (2017-04-26 03:11:41 UTC) #10
Michael Achenbach
This revert seems to break API stability: https://build.chromium.org/p/client.v8.chromium/builders/Linux%20V8%20API%20Stability/builds/2173/ See: https://github.com/v8/v8/wiki/API-stability
3 years, 8 months ago (2017-04-26 09:36:32 UTC) #11
haraken
3 years, 8 months ago (2017-04-26 09:47:20 UTC) #12
Message was sent while issue was closed.
On 2017/04/26 09:36:32, Michael Achenbach wrote:
> This revert seems to break API stability:
>
https://build.chromium.org/p/client.v8.chromium/builders/Linux%20V8%20API%20S...
> 
> See:
> https://github.com/v8/v8/wiki/API-stability

Sorry about that. We reverted this CL immediately. (So there should be no issue
now.)

Powered by Google App Engine
This is Rietveld 408576698