Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 2838903004: Revert of Roll clang 300839:301274. (Closed)

Created:
3 years, 8 months ago by hans
Modified:
3 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, ukai+watch_chromium.org, Reid Kleckner, dmikurube+clang_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll clang 300839:301274. (patchset #1 id:1 of https://codereview.chromium.org/2842663002/ ) Reason for revert: Broke WebKit Mac Builder(dbg) http://builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/197185 Assertion failed: (LocationKind == Implicit || LocationKind == Unknown) Original issue's description: > Roll clang 300839:301274. > > BUG=714769 > > Review-Url: https://codereview.chromium.org/2842663002 > Cr-Commit-Position: refs/heads/master@{#467001} > Committed: https://chromium.googlesource.com/chromium/src/+/09a607ae4637ace31251bd434527772c0aed313f TBR=thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=714769 Review-Url: https://codereview.chromium.org/2838903004 Cr-Commit-Position: refs/heads/master@{#467003} Committed: https://chromium.googlesource.com/chromium/src/+/cde7b8180ec37363ff3147cfbb40450b29548160

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
hans
Created Revert of Roll clang 300839:301274.
3 years, 8 months ago (2017-04-25 16:10:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838903004/1
3 years, 8 months ago (2017-04-25 16:11:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/cde7b8180ec37363ff3147cfbb40450b29548160
3 years, 8 months ago (2017-04-25 16:11:39 UTC) #6
Nico
On 2017/04/25 16:11:39, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 8 months ago (2017-04-25 16:54:48 UTC) #7
hans
3 years, 8 months ago (2017-04-25 17:03:01 UTC) #8
Message was sent while issue was closed.
On 2017/04/25 16:54:48, Nico wrote:
> On 2017/04/25 16:11:39, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/chromium/src/+/cde7b8180ec37363ff3147cfbb40...
> 
> Lgtm -- how did the trybots miss this? :-/

I haven't looked into it yet, but will follow up on the bug.

Powered by Google App Engine
This is Rietveld 408576698