|
|
Chromium Code Reviews|
Created:
3 years, 7 months ago by hans Modified:
3 years, 7 months ago Reviewers:
Nico CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, dmikurube+clang_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll clang 300839:301274.
BUG=714769
Review-Url: https://codereview.chromium.org/2842663002
Cr-Commit-Position: refs/heads/master@{#467001}
Committed: https://chromium.googlesource.com/chromium/src/+/09a607ae4637ace31251bd434527772c0aed313f
Patch Set 1 #
Messages
Total messages: 16 (9 generated)
The CQ bit was checked by hans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Roll clang 300839:301274. Ran `tools/clang/scripts/upload_revision.py 301274`. ========== to ========== Roll clang 300839:301274. BUG=714769 ==========
hans@chromium.org changed reviewers: + thakis@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Just waiting for linux_chromium_chromeos_dbg_ng Please take a look.
"took too much time but not ready: clang-4.2.1-cross-r301274-1 1" is harmless you think? If so, lgtm.
On 2017/04/25 15:25:01, Nico wrote: > "took too much time but not ready: clang-4.2.1-cross-r301274-1 1" is harmless > you think? Yes, the dashboard linked in the email looks fine, so as far as I can tell we should be good to go.
The CQ bit was checked by hans@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493135320570040, "parent_rev":
"1920c68e77540a5a35e52fba0860f1b8a6262e57", "commit_rev":
"09a607ae4637ace31251bd434527772c0aed313f"}
Message was sent while issue was closed.
Description was changed from ========== Roll clang 300839:301274. BUG=714769 ========== to ========== Roll clang 300839:301274. BUG=714769 Review-Url: https://codereview.chromium.org/2842663002 Cr-Commit-Position: refs/heads/master@{#467001} Committed: https://chromium.googlesource.com/chromium/src/+/09a607ae4637ace31251bd434527... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/09a607ae4637ace31251bd434527...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2838903004/ by hans@chromium.org. The reason for reverting is: Broke WebKit Mac Builder(dbg) http://builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/197185 Assertion failed: (LocationKind == Implicit || LocationKind == Unknown).
Message was sent while issue was closed.
Findit(https://goo.gl/kROfz5) confirmed this CL at revision 467001 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
